-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17270/
-----------------------------------------------------------
(Updated Feb. 7, 2014, 10:31 a.m.)
Review request for Aurora, Jonathan Boulle and Bill Farner.
Changes
-------
Improve lazy registration of command line nouns.
This gets rid of the "registered" field, and uses the actual
initialization status of the nouns map directly to determine
whether or not nouns are registered. With this change, it will
not cause any problems if subclasses of CommandLine do not
call the superclass "register_nouns" method.
Bugs: aurora-76
https://issues.apache.org/jira/browse/aurora-76
Repository: aurora
Description
-------
Bridge framework for client v2.
Diffs (updated)
-----
src/main/python/apache/aurora/client/bin/BUILD
19fd9d34ec2bfab9b8fb5ea7b468bb0b0db6341b
src/main/python/apache/aurora/client/cli/BUILD
63954d6709b4aac32661f306e1809363bdac2aae
src/main/python/apache/aurora/client/cli/__init__.py
14a66762c5217f2eeb6f0762278ed460f72c745d
src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION
src/main/python/apache/aurora/client/cli/client.py PRE-CREATION
src/test/python/apache/aurora/client/cli/BUILD
51cc3806736ee277b76e4f3609a07cc2a910f31e
src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION
src/test/python/apache/aurora/client/cli/test_cancel_update.py
92de1b953efb865157b297909ade4b5c49f6e84a
src/test/python/apache/aurora/client/cli/test_create.py
330bde5ca019ed468935cfe846b4f2a3fad209cc
src/test/python/apache/aurora/client/cli/test_diff.py
32433c17322e52c4ffb005bcc620fba56e728879
src/test/python/apache/aurora/client/cli/test_kill.py
9c593b923bba483e6877c5acc770a8ecb5fd5dbe
src/test/python/apache/aurora/client/cli/test_quota.py
d582fce95a95d611b3474f01d6639654b476de84
src/test/python/apache/aurora/client/cli/test_restart.py
3c0443339fca135dd3a2829a77e673fa9bb88cdb
src/test/python/apache/aurora/client/cli/test_status.py
38e14b1403a14c3a622bf0c498f63aa3ae38ad04
src/test/python/apache/aurora/client/cli/test_update.py
c469da4a1aead30426881dd65d82dd182f14b2bf
Diff: https://reviews.apache.org/r/17270/diff/
Testing
-------
[sun-wukong incubator-aurora (bridge)]$ ./pants
src/test/python/apache/aurora/client:all
Build operating on targets:
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 2 items
src/test/python/apache/aurora/client/test_binding_helper.py ..
================================= 2 passed in 0.31 seconds
==================================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/test_config.py ......
================================= 6 passed in 0.41 seconds
==================================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/api/test_disambiguator.py ......
================================= 6 passed in 0.28 seconds
==================================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/client/api/test_job_monitor.py .
================================= 1 passed in 0.23 seconds
==================================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/api/test_restarter.py ......
================================= 6 passed in 0.22 seconds
==================================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 47 items / 1 skipped
src/test/python/apache/aurora/client/api/test_scheduler_client.py
...............................................
=========================== 47 passed, 1 skipped in 0.60 seconds
============================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 20 items
src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
src/test/python/apache/aurora/client/api/test_health_check.py ............
================================= 20 passed in 0.25 seconds
=================================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 26 items
src/test/python/apache/aurora/client/api/test_updater.py
..........................
================================= 26 passed in 0.44 seconds
=================================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 6 items
src/test/python/apache/aurora/client/api/test_quota_check.py ......
================================= 6 passed in 0.10 seconds
==================================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 17 items
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_kill.py .....
src/test/python/apache/aurora/client/cli/test_status.py .....
src/test/python/apache/aurora/client/cli/test_diff.py ...
================================= 17 passed in 0.66 seconds
=================================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 4 items
src/test/python/apache/aurora/client/cli/test_bridge.py ....
================================= 4 passed in 0.08 seconds
==================================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 24 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ...
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
================================= 24 passed in 1.31 seconds
=================================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/client/commands/test_run.py .
================================= 1 passed in 0.36 seconds
==================================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 1 items
src/test/python/apache/aurora/client/commands/test_ssh.py .
================================= 1 passed in 0.30 seconds
==================================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 12 items
src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
================================= 12 passed in 0.23 seconds
=================================
==================================== test session starts
====================================
platform darwin -- Python 2.7.2 -- pytest-2.5.1
collected 4 items
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
================================= 4 passed in 0.23 seconds
==================================
src.test.python.apache.aurora.client.api.disambiguator
..... SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher
..... SUCCESS
src.test.python.apache.aurora.client.api.job_monitor
..... SUCCESS
src.test.python.apache.aurora.client.api.quota_check
..... SUCCESS
src.test.python.apache.aurora.client.api.restarter
..... SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client
..... SUCCESS
src.test.python.apache.aurora.client.api.updater
..... SUCCESS
src.test.python.apache.aurora.client.binding_helper
..... SUCCESS
src.test.python.apache.aurora.client.cli.bridge
..... SUCCESS
src.test.python.apache.aurora.client.cli.job
..... SUCCESS
src.test.python.apache.aurora.client.commands.core
..... SUCCESS
src.test.python.apache.aurora.client.commands.run
..... SUCCESS
src.test.python.apache.aurora.client.commands.ssh
..... SUCCESS
src.test.python.apache.aurora.client.config
..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api
..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
..... SUCCESS
[sun-wukong incubator-aurora (bridge)]$
V1 COMMAND:
[sun-wukong incubator-aurora (bridge)]$ ./dist/client.pex version
Aurora client build info:
sha: 18afec3ae3a5d896f69984784a1dbc6e0e743e44
date: Thursday Jan 23, 2014
Aurora API version: APIVersion(major=3)
V2 COMMAND:
[sun-wukong incubator-aurora (bridge)]$ ./dist/client.pex job status
usage: client.pex job status [-h] [--json] jobspec
client.pex job status: error: too few arguments
Thanks,
Mark Chu-Carroll
