-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17752/#review33947
-----------------------------------------------------------



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/17752/#comment63771>

    s/a instance/an instance/



src/main/python/apache/aurora/client/cli/options.py
<https://reviews.apache.org/r/17752/#comment63772>

    no context here!



src/main/python/apache/aurora/client/cli/task.py
<https://reviews.apache.org/r/17752/#comment63773>

    you've already intified it, fwiw


- Jonathan Boulle


On Feb. 7, 2014, 6:55 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17752/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 6:55 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: aurora-124
>     https://issues.apache.org/jira/browse/aurora-124
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add task noun, supporting "run" and "ssh" verbs.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 63954d6709b4aac32661f306e1809363bdac2aae 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 14a66762c5217f2eeb6f0762278ed460f72c745d 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> caff6d824d9f43cc9eb0c738ea6bb489321d4669 
>   src/main/python/apache/aurora/client/cli/options.py 
> 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 
>   src/main/python/apache/aurora/client/cli/task.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 51cc3806736ee277b76e4f3609a07cc2a910f31e 
>   src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17752/diff/
> 
> 
> Testing
> -------
> 
> [sun-wukong incubator-aurora (tasknoun)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
> collected 25 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .....
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> ========================== 25 passed in 1.37 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> =========================== 2 passed in 0.30 seconds 
> ===========================
> src.test.python.apache.aurora.client.cli.job                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.task                                 
>   .....   SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to