-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17913/#review34094
-----------------------------------------------------------

Ship it!



src/main/python/apache/aurora/executor/common/sandbox.py
<https://reviews.apache.org/r/17913/#comment64065>

    chown/chmod



src/main/python/apache/aurora/executor/common/sandbox.py
<https://reviews.apache.org/r/17913/#comment64066>

    swap IOError, OSError


- Jonathan Boulle


On Feb. 10, 2014, 7:19 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17913/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 7:19 p.m.)
> 
> 
> Review request for Aurora and Jonathan Boulle.
> 
> 
> Bugs: AURORA-204
>     https://issues.apache.org/jira/browse/AURORA-204
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make sandboxes safer.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/sandbox.py 
> f1fe4d5c754c0a0bb9f05f3190a74c1cfbb68238 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> cc4e517ec94bed5a49bed00ebd337a921963a811 
>   src/test/python/apache/aurora/executor/common/test_directory_sandbox.py 
> f8231fb0f226a97c7b3ff3eb1e8ca75c8e30a945 
> 
> Diff: https://reviews.apache.org/r/17913/diff/
> 
> 
> Testing
> -------
> 
> mba=aurora=; ./pants 
> src/test/python/apache/aurora/executor/common:directory_sandbox -v
> Build operating on targets: 
> OrderedSet([PythonTests(src/test/python/apache/aurora/executor/common/BUILD:directory_sandbox)])
> ============================================= test session starts 
> ==============================================
> platform darwin -- Python 2.7.6 -- py-1.4.20 -- pytest-2.5.2 -- 
> /Users/wickman/Python/CPython-2.7.6/bin/python2.7
> collected 5 items 
> 
> src/test/python/apache/aurora/executor/common/test_directory_sandbox.py:27: 
> test_directory_sandbox PASSED
> src/test/python/apache/aurora/executor/common/test_directory_sandbox.py:43: 
> test_create PASSED
> src/test/python/apache/aurora/executor/common/test_directory_sandbox.py:64: 
> test_user_does_not_exist PASSED
> src/test/python/apache/aurora/executor/common/test_directory_sandbox.py:77: 
> test_create_ioerror PASSED
> src/test/python/apache/aurora/executor/common/test_directory_sandbox.py:87: 
> test_destroy_ioerror PASSED
> 
> =========================================== 5 passed in 0.07 seconds 
> ===========================================
> src.test.python.apache.aurora.executor.common.directory_sandbox               
>   .....   SUCCESS
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Reply via email to