> On Feb. 13, 2014, 6:29 p.m., Suman Karumuri wrote:
> > src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java, line 
> > 40
> > <https://reviews.apache.org/r/18036/diff/1/?file=483735#file483735line40>
> >
> >     It is not logged by the library. I prefer to have this since it 
> > provides visibility into the logic mentioned in the previous comment.
> 
> Bill Farner wrote:
>     It's logged, just at FINE.  IMHO this is noise unless we're actively 
> debugging, in which case you can bump the log level.

Didn't realize there was a FINE log level. Removed.


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18036/#review34387
-----------------------------------------------------------


On Feb. 13, 2014, 10:56 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18036/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 10:56 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-211
>     https://issues.apache.org/jira/browse/AURORA-211
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Also added additional logging to UIRedirectFilter to expose the order in 
> which filters are being applied.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
> ba37e26bba4e1ad4c546e73748182deb2d5942a7 
> 
> Diff: https://reviews.apache.org/r/18036/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build
> tested on localhost, verified behavior via log statements.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Reply via email to