> On Feb. 11, 2014, 4:33 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/commands/admin.py, line 174
> > <https://reviews.apache.org/r/17877/diff/1/?file=481150#file481150line174>
> >
> >     Die expects a message string, not an exception object. die('Invalid 
> > unit specification') would end up with a better error message.
> >

Oh yeah, I can see the the problem with not passing a string. I feel like the 
default exception message provides a better explanation of what was wrong with 
the argument though:

./pants py src/main/python/apache/aurora/client/bin:aurora_admin set_quota 
example role 10 a b
FATAL] Invalid size: Amount did not have a valid base: a.  Valid bases: kb gb g 
mb tb k m t


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/#review34193
-----------------------------------------------------------


On Feb. 10, 2014, 7:17 p.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17877/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 7:17 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-200
>     https://issues.apache.org/jira/browse/AURORA-200
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-200: set_quota should die if given invalid arguments
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 45686aec8d69f0dfa1d649a92a19ca87bd315823 
> 
> Diff: https://reviews.apache.org/r/17877/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build && ./pants src/test/python:all -vxs along with manual 
> testing w/ bad arguments.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Reply via email to