----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/#review34515 -----------------------------------------------------------
src/main/python/apache/aurora/client/cli/options.py <https://reviews.apache.org/r/17752/#comment64612> Minor nit: I think the original version of this was --user. Also since we're mirroring the -L form for creating tunnels, consider adding the '-l' short form for --ssh_user. src/main/python/apache/aurora/client/cli/task.py <https://reviews.apache.org/r/17752/#comment64613> any reason why '-t' short form is removed? for me '-t50' is almost muscle memory. - Brian Wickman On Feb. 12, 2014, 2:16 a.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17752/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 2:16 a.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Bugs: aurora-124 > https://issues.apache.org/jira/browse/aurora-124 > > > Repository: aurora > > > Description > ------- > > Add task noun, supporting "run" and "ssh" verbs. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/BUILD > f5c9ae75d7a26883d90b9bd8ac9c80cd436d03a1 > src/main/python/apache/aurora/client/cli/client.py > e416d3879cc5943ec5ab3931a8b1aedb85a379a9 > src/main/python/apache/aurora/client/cli/jobs.py > caff6d824d9f43cc9eb0c738ea6bb489321d4669 > src/main/python/apache/aurora/client/cli/options.py > 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 > src/main/python/apache/aurora/client/cli/task.py PRE-CREATION > src/test/python/apache/aurora/client/cli/BUILD > c106b97a0902da5cd791b18117da3198bfb43b8c > src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION > > Diff: https://reviews.apache.org/r/17752/diff/ > > > Testing > ------- > > [sun-wukong incubator-aurora (tasknoun)]$ ./pants > src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > ============================= test session starts > ============================== > platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 > collected 25 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py .... > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py ..... > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ..... > src/test/python/apache/aurora/client/cli/test_update.py ... > > ========================== 25 passed in 1.37 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_task_run.py .. > > =========================== 2 passed in 0.30 seconds > =========================== > src.test.python.apache.aurora.client.cli.job > ..... SUCCESS > src.test.python.apache.aurora.client.cli.task > ..... SUCCESS > > > Thanks, > > Mark Chu-Carroll > >
