----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18141/#review34749 -----------------------------------------------------------
Ship it! Ship It! - Maxim Khutornenko On Feb. 18, 2014, 7:16 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18141/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 7:16 p.m.) > > > Review request for Aurora, Deprecated Use kevints and Maxim Khutornenko. > > > Bugs: AURORA-214 > https://issues.apache.org/jira/browse/AURORA-214 > > > Repository: aurora > > > Description > ------- > > This change also alters the signature to and renames TaskLauncher#createTask, > since no remaining TaskLaunchers return a task. The signature change > resulted in removing MesosSchedulerImpl#fitsInOffer, which turned out to be > redundant in practice (GcExecutorLauncher did this internally). > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java > 70ac62e6ba3566a8789f1c7b2042b8a94f5f3c02 > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java > 92399cc7a38f0ddce8338d127fb7b579606f2571 > src/main/java/org/apache/aurora/scheduler/TaskLauncher.java > 96a3adee537aa87402a39dba090c6bbebe6afb1f > src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java > 010776efe1620c13bbcff611f9c1c3272d6c776f > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java > e7a5a8377f4c8a42012e7ecb118c597a2804da40 > src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java > f0d4fbcc411dcb3642c21f51f65c89ad24c3400a > src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java > 92c77d53f09c39e710bd1bb3277f32d1e144e62f > src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java > ecf4f90c7d635f912f90fb367dbaa11401048052 > > src/test/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncherTest.java > 98f5aa141ecca7475274d84f50c750db6f2908b5 > > Diff: https://reviews.apache.org/r/18141/diff/ > > > Testing > ------- > > $ ./gradlew build > > > Thanks, > > Bill Farner > >
