> On Feb. 18, 2014, 10:15 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/cli/options.py, line 70
> > <https://reviews.apache.org/r/18153/diff/3/?file=496781#file496781line70>
> >
> >     is 100 an incorrect percentile?  100th percentile means max() right?
> 
> Brian Wickman wrote:
>     derp, nevermind, the internet wins:
>     http://en.wikipedia.org/wiki/Percentile

feels like a lack of unit testing here. Added boundary condition testing.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/#review34788
-----------------------------------------------------------


On Feb. 18, 2014, 10:52 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18153/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 10:52 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-207
>     https://issues.apache.org/jira/browse/AURORA-207
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added "sla get_job_uptime" command.
> 
> Also, changed from ValueError to ArgumentTypeError in options.py as the 
> former is not handled properly by argparser and no custom messages were 
> reported.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> b69d20818836fb6ae87b333e33008b27e013954f 
>   src/main/python/apache/aurora/client/cli/options.py 
> 37f416d563b526cccf3c9cab69a5df15873db250 
>   src/main/python/apache/aurora/client/cli/sla.py 
> a3973df870567052083b1d5a524438191eb6d812 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
>   src/test/python/apache/aurora/client/cli/test_sla.py 
> 703d39e4566a30900f1e9bcca5871c4a426cc6c3 
> 
> Diff: https://reviews.apache.org/r/18153/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to