----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18240/#review34866 -----------------------------------------------------------
Ship it! src/main/java/org/apache/aurora/scheduler/storage/Storage.java <https://reviews.apache.org/r/18240/#comment65251> typo - Maxim Khutornenko On Feb. 18, 2014, 9:55 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18240/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 9:55 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-135 > https://issues.apache.org/jira/browse/AURORA-135 > > > Repository: aurora > > > Description > ------- > > I've also done some tidying of the storage interfaces here, which make code > simpler in several places: > > - Introduced LockType in ReadWriteLockManager to make parameterized > lock/unlock possible > - Introduced StorageOperation as a base interface for Work and MutateWork. > - Moved Storage#snapshot() to NonVolatileStorage > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java > ef7d2ce30a24bad544546a048ee6f6c6ce8681f5 > src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java > a02991453def78bbf6a00c8946d2079fdc4539e9 > src/main/java/org/apache/aurora/scheduler/storage/Storage.java > 9cc1d1e871bc34fd244565a692215b9657e164a8 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > 36e4082acceb3045ef92a5957b500e407bfc1247 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java > 30d77cc86fba569cfaa35ae69d97726072660aed > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 7f7e34d1cf379168be6fffab0faaf450151a10bc > > src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java > 5dc7df18325f9a637ef9009197555e8d53c3b498 > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > f708ab3c2fa5d50b084e037f9cc0cb998935120a > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 656e44eb51508c7ab05af8b91e9dcec216d48984 > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java > 2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d > > Diff: https://reviews.apache.org/r/18240/diff/ > > > Testing > ------- > > ./gradlew build > > > Thanks, > > Bill Farner > >
