----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18265/#review34876 -----------------------------------------------------------
Ship it! src/main/python/apache/aurora/client/cli/__init__.py <https://reviews.apache.org/r/18265/#comment65258> Inconsistent use of positional file arg. - Maxim Khutornenko On Feb. 19, 2014, 1:29 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18265/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 1:29 p.m.) > > > Review request for Aurora, David Robinson and Maxim Khutornenko. > > > Bugs: aurora-220 > https://issues.apache.org/jira/browse/aurora-220 > > > Repository: aurora > > > Description > ------- > > Add configuration plugins to the clientv2 framework. > > A configuration plugin is a component that allows a commandline > to have objects which perform some kind of configuration option > ahead of actually invoking commands. For example, a configuration > plugin could add options to perform a security handshake before > connecting to a production cluster. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py > d3bd119fb0930ce6acc9e1945900a7faa840ecd5 > src/main/python/apache/aurora/client/cli/sla.py > 02002703879557f481aa2252ec2d45456042e24e > src/test/python/apache/aurora/client/cli/BUILD > f9e674928fd7610e90fdbe7129ef5d69c9b17723 > src/test/python/apache/aurora/client/cli/test_plugins.py PRE-CREATION > > Diff: https://reviews.apache.org/r/18265/diff/ > > > Testing > ------- > > [sun-wukong incubator-aurora (plugins)]$ ./pants > src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py .... > > =========================== 4 passed in 0.02 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py ..... > > =========================== 5 passed in 0.47 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 25 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py .... > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py ..... > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ..... > src/test/python/apache/aurora/client/cli/test_update.py ... > > ========================== 25 passed in 1.63 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_plugins.py .. > > =========================== 2 passed in 0.49 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 3 items > > src/test/python/apache/aurora/client/cli/test_quota.py ... > > =========================== 3 passed in 0.49 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_sla.py .. > > =========================== 2 passed in 0.48 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_task_run.py .. > > =========================== 2 passed in 0.50 seconds > =========================== > src.test.python.apache.aurora.client.cli.bridge > ..... SUCCESS > src.test.python.apache.aurora.client.cli.help > ..... SUCCESS > src.test.python.apache.aurora.client.cli.job > ..... SUCCESS > src.test.python.apache.aurora.client.cli.plugins > ..... SUCCESS > src.test.python.apache.aurora.client.cli.quota > ..... SUCCESS > src.test.python.apache.aurora.client.cli.sla > ..... SUCCESS > src.test.python.apache.aurora.client.cli.task > ..... SUCCESS > [sun-wukong incubator-aurora (plugins)]$ > > > Thanks, > > Mark Chu-Carroll > >