-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18267/#review35037
-----------------------------------------------------------



src/main/python/apache/aurora/client/cli/options.py
<https://reviews.apache.org/r/18267/#comment65401>

    what if args is e.g. ('-p', '--port')?



src/main/python/apache/aurora/client/cli/options.py
<https://reviews.apache.org/r/18267/#comment65395>

    self.type = kwargs.get('type')



src/main/python/apache/aurora/client/cli/options.py
<https://reviews.apache.org/r/18267/#comment65396>

    self.help = kwargs.get('help', '')



src/main/python/apache/aurora/client/cli/options.py
<https://reviews.apache.org/r/18267/#comment65397>

    self.kwargs.get('required', not self.name.startswith('--'))
    



src/main/python/apache/aurora/client/cli/options.py
<https://reviews.apache.org/r/18267/#comment65398>

    self.type is str



src/main/python/apache/aurora/client/cli/options.py
<https://reviews.apache.org/r/18267/#comment65399>

    isinstance(self.type, Compatibility.string)
    



src/main/python/apache/aurora/client/cli/options.py
<https://reviews.apache.org/r/18267/#comment65400>

    isinstance(self.type, Compatibility.integer)


- Brian Wickman


On Feb. 19, 2014, 1:34 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18267/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 1:34 p.m.)
> 
> 
> Review request for Aurora, David Robinson and Brian Wickman.
> 
> 
> Bugs: aurora-203
>     https://issues.apache.org/jira/browse/aurora-203
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement help message generation for the noun/verb framework.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/bridge.py 
> 27079da1430d1b6b36d64c9176797f803db6ff62 
>   src/main/python/apache/aurora/client/cli/client.py 
> 56d63660850b7a3a437cb3575b9ba8add8813956 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1cbde5ee529a208114dd5c767cd9039ddc3cb931 
> 
> Diff: https://reviews.apache.org/r/18267/diff/
> 
> 
> Testing
> -------
> 
> [sun-wukong incubator-aurora (bridgehelp)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
> 
> =========================== 4 passed in 0.02 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 25 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .....
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> ========================== 25 passed in 1.61 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_quota.py ...
> 
> =========================== 3 passed in 0.49 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py ..
> 
> =========================== 2 passed in 0.49 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> =========================== 2 passed in 0.50 seconds 
> ===========================
> src.test.python.apache.aurora.client.cli.bridge                               
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.job                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.quota                                
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.sla                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.task                                 
>   .....   SUCCESS
> [sun-wukong incubator-aurora (bridgehelp)]$
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to