> On Feb. 21, 2014, 2:55 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/api/sla.py, line 88
> > <https://reviews.apache.org/r/18296/diff/1/?file=498483#file498483line88>
> >
> >     This comment doesn't make sense to me. I don't understand what an 
> > instance of this class is. Is it a list of hosts? 
> >     
> >     Maybe start the comment with what the thing is, and then explain what 
> > it does?

Fair suggestion. Commented on the class purpose and get_safe_hosts algorithm.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18296/#review35150
-----------------------------------------------------------


On Feb. 20, 2014, 1:15 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18296/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 1:15 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-208
>     https://issues.apache.org/jira/browse/AURORA-208
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented admin_client sla_list_safe_domain command.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0999b6f99bd74361663258cdae9d3920b3bb636f 
>   src/main/python/apache/aurora/client/api/sla.py 
> b0b2b245951ea72d113ff2b3969c4d54024f73e7 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 45686aec8d69f0dfa1d649a92a19ca87bd315823 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 2e6c8faf668182b497df59fe41b74af240459de7 
>   src/test/python/apache/aurora/client/commands/BUILD 
> 02c27aa513d60ef901f446c56cbfc0d891445e30 
>   src/test/python/apache/aurora/client/commands/test_admin_sla.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/client/commands/util.py 
> 11ae990c0d8e41470c6df438d37d8a2a79907a58 
> 
> Diff: https://reviews.apache.org/r/18296/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/client:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to