-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18440/#review35426
-----------------------------------------------------------



src/main/python/apache/aurora/client/api/sla.py
<https://reviews.apache.org/r/18440/#comment65914>

    Echo of dealing with val types in a strongly typed language :) Changed.



src/main/python/apache/aurora/client/api/sla.py
<https://reviews.apache.org/r/18440/#comment65917>

    Good point. Fixed.



src/main/python/apache/aurora/client/api/sla.py
<https://reviews.apache.org/r/18440/#comment65922>

    Sure, fixed.



src/main/python/apache/aurora/client/api/sla.py
<https://reviews.apache.org/r/18440/#comment65925>

    Line wrapping it is. Done.



src/main/python/apache/aurora/client/commands/admin.py
<https://reviews.apache.org/r/18440/#comment65927>

    Done.



src/main/python/apache/aurora/client/commands/admin.py
<https://reviews.apache.org/r/18440/#comment65928>

    Was not sure about sorting applied to items(). Done.



src/main/python/apache/aurora/client/commands/admin.py
<https://reviews.apache.org/r/18440/#comment65937>

    The "inf" reads "infeasible" and "infinite" - both would be right here. 
Also, "inf" is easier to parse from a shell script.
    
    That said, I don't feel strong about it as "n/a" is definitely 
self-explanatory. Changed.



src/main/python/apache/aurora/client/commands/admin.py
<https://reviews.apache.org/r/18440/#comment65938>

    Done.


- Maxim Khutornenko


On Feb. 25, 2014, 1 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18440/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 1 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-209
>     https://issues.apache.org/jira/browse/AURORA-209
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented sla_probe_hosts command.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> fd5edd1c8dffa99fd42c0e01ecfa8ec832a4a602 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 2778545b7cf42c20fb44e2fdb5b661556e84234f 
>   src/test/python/apache/aurora/client/commands/test_admin_sla.py 
> 780ad180366a5b8664367e499fe86470418c1344 
> 
> Diff: https://reviews.apache.org/r/18440/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to