> On Feb. 25, 2014, 7:46 p.m., Bill Farner wrote: > > build-support/virtualenv, line 19 > > <https://reviews.apache.org/r/18345/diff/3/?file=503119#file503119line19> > > > > I may be missing something, but isn't the pushd/popd obviated by the cd? > > Kevin Sweeney wrote: > The cd only happens in the subshell ($()), which is a different process > than the parent.
Ah, duh — thanks! - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35444 ----------------------------------------------------------- On Feb. 25, 2014, 2:45 a.m., Dan Norris wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18345/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2014, 2:45 a.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-225 > https://issues.apache.org/jira/browse/AURORA-225 > > > Repository: aurora > > > Description > ------- > > AURORA-225: Shell scripts in checkout should use an absolute path > > > Diffs > ----- > > build-support/pex cd083d996884681acf6f731ed24037342f2309bf > build-support/virtualenv d7a99e0c3934afba55e131850a202b6e706cec8a > pants 4dc17fd365d8fd120c162905c41f29d92788011f > rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 > > Diff: https://reviews.apache.org/r/18345/diff/ > > > Testing > ------- > > Submitted this review with the following command: > ../rbt post -o -g (from inside of build-support directory) > > > Thanks, > > Dan Norris > >
