-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18487/
-----------------------------------------------------------

Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Repository: aurora


Description
-------

There are a few nice things falling out of this refactor:
- New methods on mutable store interfaces are not implicitly forwarded
  (ForwardingStore does not implement mutable stores).
- Write ahead/behind behavior is more obvious in LogStorage
  (i found the delegation by calling super tough to catch mistakes.)
- Callers with a handle on LogStorage don't have a means to invoke mutate calls 
outside of a transaction
  (they only get access to mutable stores in write(), which obviated 
testMutateRequiresWriteOperation)
- the boolean recovered flag disappears, making LogStorage.write() easier to 
reason about
  (CallOrderEnforcingStorage helps bolster this.)


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
34d39f2e9064b67ca226c13bb7e330f4daa2a2aa 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
1842210c91ee3e153f5d142266bc2696960535af 
  src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
d6624f470eadaf0be658db1d87d5863ea6701d94 

Diff: https://reviews.apache.org/r/18487/diff/


Testing
-------

./gradlew build


Thanks,

Bill Farner

Reply via email to