> On Feb. 25, 2014, 11:11 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/base/Jobs.java, line 48 > > <https://reviews.apache.org/r/17303/diff/1/?file=447775#file447775line48> > > > > This uses time so it should take a Clock instance for testing.
Since we got rid of mostRecentFailures logic, this code is dropped now. > On Feb. 25, 2014, 11:11 p.m., Kevin Sweeney wrote: > > src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java, line 19 > > <https://reviews.apache.org/r/17303/diff/1/?file=447781#file447781line19> > > > > How would you feel about naming this TaskFixtures or TaskTestUtil? Done. > On Feb. 25, 2014, 11:11 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/base/Tasks.java, line 192 > > <https://reviews.apache.org/r/17303/diff/1/?file=447776#file447776line192> > > > > explicit orderings will throw RuntimeExceptions if they encounter a > > value not in the explicit set. It doesn't seem to me that STATUSES is > > exhaustive and I don't see test coverage to guarantee that in the future. Good catch. Updated the list to be exhaustive. Added a test case to test the same. > On Feb. 25, 2014, 11:11 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/base/Tasks.java, line 191 > > <https://reviews.apache.org/r/17303/diff/1/?file=447776#file447776line191> > > > > Why the indirection? Why not call this latestActiveTask? Updated comment to make this clear. Can't use latestActiveTask since a job may have just finished but it's taskConfig is not a representative task config for the job. - Suman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/#review33465 ----------------------------------------------------------- On Jan. 24, 2014, 7:13 a.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17303/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 7:13 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-64 > https://issues.apache.org/jira/browse/AURORA-64 > > > Repository: aurora > > > Description > ------- > > Added task stats to getJobs API so it can be used by the role page in the UI. > Refactored code from SchedulerzRole and SchedulerzRoleTest into relevant > classes so it can be used by the UI and the thrift API. > Added tests for new code. > Moved populateJobConfig call into ReadOnlyScheduler. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/base/Jobs.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/base/Tasks.java > 06a19d80483b6949c9851b5d38fe34ac712aa75e > src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java > b0caca73b46fba928fb718ab45a608dad4685a2f > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > cf9099f307efa23ca34634e3512d9cdbebfa82f2 > src/main/thrift/org/apache/aurora/gen/api.thrift > 74010379baa2e47cefc228943f766c7b3a8b0d97 > src/test/java/org/apache/aurora/scheduler/base/JobsTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/SchedulerzRoleTest.java > 912be189583419e7201e45650d18cd24a6a5a35b > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 6cefdfad469a9b69a5291ad46be1df14b443472e > src/test/resources/org/apache/aurora/gen/api.thrift.md5 > 42fdca2759f15d007bee058485c237268c57597a > > Diff: https://reviews.apache.org/r/17303/diff/ > > > Testing > ------- > > gradle clean build > gradle run to test local UI. > > > Thanks, > > Suman Karumuri > >
