> On Jan. 28, 2014, 3:36 a.m., Bill Farner wrote: > > src/main/thrift/org/apache/aurora/gen/api.thrift, line 219 > > <https://reviews.apache.org/r/17347/diff/1/?file=450737#file450737line219> > > > > This confirms my fear of the slippery slope of Quota becoming an > > overloaded term. I'd love to call this something that doesn't already have > > an implied meaning about production=True. > > > > Mind taking a detour to address this TODO? > > grep -R ResourceAggregate src/main/java/ > > src/main/java//org/apache/aurora/scheduler/quota/Quotas.java: // > > TODO(Suman Karumuri): Rename Quota to something more meaningful (ex: > > ResourceAggregate) > > > > It's really important to do this before we cut our first release (in > > the next few weeks in theory), since we need to adhere to a stable API at > > that point.
Done. https://reviews.apache.org/r/18546/ Will update this review, once the above review is merged. - Suman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17347/#review32946 ----------------------------------------------------------- On Jan. 25, 2014, 12:48 a.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17347/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2014, 12:48 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-65 > https://issues.apache.org/jira/browse/AURORA-65 > > > Repository: aurora > > > Description > ------- > > This call will be used by the role page in the UI. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > cf9099f307efa23ca34634e3512d9cdbebfa82f2 > src/main/thrift/org/apache/aurora/gen/api.thrift > 74010379baa2e47cefc228943f766c7b3a8b0d97 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 6cefdfad469a9b69a5291ad46be1df14b443472e > src/test/resources/org/apache/aurora/gen/api.thrift.md5 > 42fdca2759f15d007bee058485c237268c57597a > > Diff: https://reviews.apache.org/r/17347/diff/ > > > Testing > ------- > > gradle clean build. > > > Thanks, > > Suman Karumuri > >
