-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18526/#review35722
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/base/Query.java
<https://reviews.apache.org/r/18526/#comment66435>

    Makes sense for this to call over to the overload.  Also, avoid the extra 
list creation:
    
    return bySlave(ImmutableSet.<String>builder()
        .add(slaveHost)
        .add(slaveHosts)
        .build());



src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java
<https://reviews.apache.org/r/18526/#comment66436>

    I know why you're doing this here, but mind keeping it out for now?



src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java
<https://reviews.apache.org/r/18526/#comment66440>

    This method allows slaveHost to hide slaveHosts.  Here's an implementation 
that behaves more sanely when both are set.  A test for this sane behavior 
would be nice as well.
    
    ImmutableSet.Builder<String> hosts = ImmutableSet.builder();
    if (query.get().isSetSlaveHost()) {
      hosts.add(query.get().getSlaveHost());
    }
    if (query.get().isSetSlaveHosts()) {
      hosts.addAll(query.get().getSlaveHosts());
    }
    
    return hosts.build();



src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java
<https://reviews.apache.org/r/18526/#comment66439>

    ImmutableSet.of()



src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java
<https://reviews.apache.org/r/18526/#comment66441>

    This signature disables the tri-state response.  The previous signature 
distinguished:
    
    1. query does not apply to the index
    2. query applies to the index, and there are no matching items
    3. query applies to the index, and there are matching items
    
    The behavior implemented here lumps (1) and (2) together.  Queries falling 
into (2) currently short-circuit, but as implemented here they will fall back 
to a full table scan.



src/main/thrift/org/apache/aurora/gen/api.thrift
<https://reviews.apache.org/r/18526/#comment66442>

    omit optional, or add it to all fields


- Bill Farner


On Feb. 27, 2014, 4:42 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18526/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 4:42 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-232
>     https://issues.apache.org/jira/browse/AURORA-232
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The slaveHosts set-based field will eventually replace a string field. 
> All internal queries are converted to use the new field. The old one is still 
> supported for queries coming from the web (until client side is refactored).
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/base/Query.java 
> b9f207c740362fafff0257988f52b6179025d58d 
>   src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
> 7337044bacd052c516e4d78a2993946d472ef91c 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 
> d1ab503e4edac86afcb8884a074a87b7536de3f7 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> cd60f47bf34b4a634004e2ad9eadad37aa1556bb 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 
> 884f589a2cbea918ecbfedf457f42d7cc9254c95 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> fafb5100443482e662db453429c5259f2ab80ae5 
> 
> Diff: https://reviews.apache.org/r/18526/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to