> On Feb. 27, 2014, 11:04 p.m., Kevin Sweeney wrote:
> > build.gradle, lines 251-260
> > <https://reviews.apache.org/r/18537/diff/1/?file=504979#file504979line251>
> >
> >     Rather than give up if /usr/bin/python isn't >=2.6,<3, shouldn't it 
> > instead check for python2.7 and python2.6 on PATH (similar to 
> >     
> >     
> > https://github.com/apache/incubator-aurora/blob/master/build-support/virtualenv#L6-L13
> >     
> >     ).

this check appears to only ensure that the python script used in the gradle 
build (thrift_wrapper_codegen.py) is able to run and that call uses whatever 
python on the path and does not use the python27 or python26 
https://github.com/apache/incubator-aurora/blob/master/build.gradle#L241

thrift_wrapper_codegen.py is only used in the java build right now and probably 
should be migrated over to a gradle task/plugin so python is not needed, but 
that should be created and tackled in another ticket if needed


- Jake


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/#review35721
-----------------------------------------------------------


On Feb. 26, 2014, 10:06 p.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18537/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 10:06 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-227
>     https://issues.apache.org/jira/browse/AURORA-227
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-227: Aurora build should check for the Python version
> 
> 
> Diffs
> -----
> 
>   build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 
>   build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 
> 
> Diff: https://reviews.apache.org/r/18537/diff/
> 
> 
> Testing
> -------
> 
> Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in:
> 
> :checkPythonVersion FAILED
> 
> FAILURE: Build failed with an exception.
> 
> * Where:
> Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257
> 
> * What went wrong:
> Execution failed for task ':checkPythonVersion'.
> > Build requires Python 2.6 or Python 2.7
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Reply via email to