> On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:
> > Mostly minor nits aside from sneaky commenting out of asserts in tests.

Thanks for the comments. Was trying to get the review out. Fixed the flaky test 
and merged the fix into this branch.


> On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:
> > build.gradle, line 238
> > <https://reviews.apache.org/r/18546/diff/1/?file=505401#file505401line238>
> >
> >     Fix sorting

Done.


> On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/Quotas.java, line 35
> > <https://reviews.apache.org/r/18546/diff/1/?file=505408#file505408line35>
> >
> >     Using the type is redundant with the javadoc.  The previous doc used 
> > 'quota' as a noun.

Done.


> On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/Quotas.java, line 39
> > <https://reviews.apache.org/r/18546/diff/1/?file=505408#file505408line39>
> >
> >     How about none()?  More concise, just as self-documenting.

Good idea. Changed.


> On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 52
> > <https://reviews.apache.org/r/18546/diff/1/?file=505423#file505423line52>
> >
> >     Please focus on breaking this habit: this is a red flag for redundancy:
> >     
> >     // Resource Aggregate is a struct...
> >     struct ResourceAggregate {

Will try harder. Things like these slip self-review also. Comment is dropped 
since the struct name is self explanatory now.


> On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:
> > src/test/python/apache/aurora/client/cli/test_diff.py, line 137
> > <https://reviews.apache.org/r/18546/diff/1/?file=505438#file505438line137>
> >
> >     This kind of change hidden in a big diff is poor form.  Please deal 
> > with this separately.

Thought this was a broken test. Turned out to be an environment issue. Also, 
fixed existing bug AURORA-101, that addresses this.


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/#review35718
-----------------------------------------------------------


On Feb. 27, 2014, 2:44 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18546/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 2:44 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim 
> Khutornenko, and Bill Farner.
> 
> 
> Bugs: AURORA-105
>     https://issues.apache.org/jira/browse/AURORA-105
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Updated client to use the new struct.
> 
> The client tests fail on my laptop. So, muted the failing assertion for now 
> and added AURORA-237.
> 
> 
> Diffs
> -----
> 
>   build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> a2008758f25d33dc000834ff0d77cba2352013ed 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> 5f7e34ee1b09fc139ae5eb41fc68a716d555721f 
>   
> src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 
> 6ff70af3975eeaf7bd3efd62eac29bc84b411b1d 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 
> c8985351fb21c010d3ae5fde5d00f25e77076b37 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
> 0e286d8d822759169a11d363f09f5322408a103c 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 9868abc2c3d216ccb7d7749df739e0a898df737d 
>   src/main/java/org/apache/aurora/scheduler/quota/Quotas.java 
> 9da3c3e9a1bd732633da8afdda89484f5f4475cb 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> e3ab1ddcc13c14e1aeec496748edaf0ecf5f0a8e 
>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
> 8855bfb2cd26f610c6ea6d87fb46abf1fd3d9970 
>   src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 
> e3dffe080e3f46bff8eae23591da7a79b5237564 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa 
>   src/main/java/org/apache/aurora/scheduler/storage/QuotaStore.java 
> 42c405ac43b6676b737c8e46a4f09bddcbeb9bed 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 1842210c91ee3e153f5d142266bc2696960535af 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> cb0ba508605cd2e98da83ef656a516e6c6e2d244 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java 
> b9bb4bb7a0f2892f29877e070d80cb900365453a 
>   
> src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
>  043dae68ede0264fad9bbf2b74aa91e9b8b0c9cc 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  dccae15a2c529025c9bb6a6f7a0220779ca4f9a1 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 37b7f428677c7f668079373d9a40e3a104c78e3b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 7de02c43438075629ff9ef93c79d8d7ecfb884c1 
>   src/main/python/apache/aurora/client/api/sla.py 
> 131c357d60fd00740b51055f555d56c599124d15 
>   src/main/python/apache/aurora/client/api/updater.py 
> 924e6d6138b3a192ff42c31588665985f8eb7d13 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> cd60f47bf34b4a634004e2ad9eadad37aa1556bb 
>   src/main/thrift/org/apache/aurora/gen/storage.thrift 
> f138c74b2790612d932d330087c6d6d8c24d1570 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaCheckResultTest.java 
> e366026df7d8d4e1e356889eefaa6fba1aa2e612 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> 82e17df016b0f1ad39f8817abe065394edb9f656 
>   src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 
> c785b1c83ea2b530566050a80214861b3b5b47da 
>   
> src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java
>  a07f3c98a72b3fccb1e1091ffa6bcafedde30247 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> d6624f470eadaf0be658db1d87d5863ea6701d94 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  69dadaf08e0c2771a0820406e8ed0c3778a83066 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  4a2d39d8b25c4a6b161c47d6ba7068d74f8a60e0 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 09a288a8c60b97bc13f72ba54762936eab391899 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 1edc0d7b224cc477ea6e8873e76ee8c70c6b4d50 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> 6b1d7bdbce84860c282792a20d15c2229164f465 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 49cab1530563862157c85a9d5df38efbeae40777 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 79ec921cf1cf1180fa4a474aa4767f674fd7767c 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> 81406a02e2b71d9db9ba84be26de2728692b102c 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> 9c23a60298024cd0f7626835a90bc821a5ede46e 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> f7d3585e3f4e412eebadad37ba0f4d698e3e42a0 
>   src/test/python/apache/aurora/client/commands/test_diff.py 
> 339459e2f563083ddbf01cadd4e938970d6ea388 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> fafb5100443482e662db453429c5259f2ab80ae5 
>   src/test/resources/org/apache/aurora/gen/storage.thrift.md5 
> 99ab2023377f4c65459c301829bde0352f41d95a 
> 
> Diff: https://reviews.apache.org/r/18546/diff/
> 
> 
> Testing
> -------
> 
> Successfully ran:
> gradle clean build  && ./pants src/test/python/apache/aurora/client:all
> On a local scheduler tested /scheduler* and /quotas end points.
> 
> Will run end to end test tonight.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Reply via email to