-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/
-----------------------------------------------------------
(Updated Feb. 27, 2014, 5:59 p.m.)
Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian
Wickman.
Changes
-------
Initialize later, add more logging (so for example someone could set the
environment variable in their .aurora file).
Bugs: AURORA-224
https://issues.apache.org/jira/browse/AURORA-224
Repository: aurora
Description
-------
Make http signaler timeout secs configurable via an environment variable. This
is a band-aid for the issue described in AURORA-224. Further improvements would
be made possible by refactoring the updater to completely remove client-side
health checking (delegating to thermos, which already supports a much richer
system of delegated health checks).
I'm open to suggestions on how to make this feature more Aurora-y - I know
environment variables have typically been discouraged since they can lead to
flaky deploys, but I don't think this setting adds unnecessary risk and I see
it as a short-term fix for some counter-intuitive behavior on our part.
Diffs (updated)
-----
src/main/python/apache/aurora/common/http_signaler.py
b19b72d6400cef1a2e469b1853a7d49c063d5a25
Diff: https://reviews.apache.org/r/18602/diff/
Testing
-------
./build-support/jenkins/build.sh
Thanks,
Kevin Sweeney
