-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18526/#review35836
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java
<https://reviews.apache.org/r/18526/#comment66606>

    I believe this entire line can be replaced with:
    
      return jobKey.asSet();



src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java
<https://reviews.apache.org/r/18526/#comment66621>

    This is O(n) for n keys in the map.  More ideal is to iterate over the 
keys.  I don't know of a 'multi-get' for Map/Multmap, but i'd support use of 
that if it does.
    
    Also, not new, but it's a good idea to wrap this with 
Iterables.unmodifiableIterable().
    


- Bill Farner


On Feb. 28, 2014, 1:18 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18526/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 1:18 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-232
>     https://issues.apache.org/jira/browse/AURORA-232
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The slaveHosts set-based field will eventually replace a string field. 
> All internal queries are converted to use the new field. The old one is still 
> supported for queries coming from the web (until client side is refactored).
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/base/Query.java 
> b9f207c740362fafff0257988f52b6179025d58d 
>   src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
> 7337044bacd052c516e4d78a2993946d472ef91c 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 
> d1ab503e4edac86afcb8884a074a87b7536de3f7 
>   src/main/python/apache/aurora/client/api/sla.py 
> 131c357d60fd00740b51055f555d56c599124d15 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> cd60f47bf34b4a634004e2ad9eadad37aa1556bb 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 
> 884f589a2cbea918ecbfedf457f42d7cc9254c95 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> fafb5100443482e662db453429c5259f2ab80ae5 
> 
> Diff: https://reviews.apache.org/r/18526/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to