> On March 4, 2014, 12:02 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/base/Query.java, line 78
> > <https://reviews.apache.org/r/18655/diff/2/?file=509070#file509070line78>
> >
> >     Iterables.getOnlyELement is a bit of a land mine.  An unsuspecting 
> > caller can hit IllegalArgumentException or NoSuchElementException.
> >     
> >     SchedulerCoreImpl.killTasks is currently victim to this.
> 
> Maxim Khutornenko wrote:
>     That's the unfortunate outcome of merging the extraction side, which I 
> have commented in the killTasks. Are you proposing to take on that 
> refactoring now?
> 
> Bill Farner wrote:
>     AFAICT you can do this one locally to this method.  The safest behavior 
> is to continue the semantic of "is this job scoped by job only?", except you 
> now have to add "and exactly one job".  This might warrant a method rename.  
> Internally, you should be able to get away with another check for 
> jobKey.get().size() == 1.

s/is this job/is this query/


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18655/#review36054
-----------------------------------------------------------


On March 3, 2014, 11:26 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18655/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 11:26 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-235
>     https://issues.apache.org/jira/browse/AURORA-235
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added an optional JobKey set filter into the TaskQuery.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 
> 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 
>   src/main/java/org/apache/aurora/scheduler/base/Query.java 
> d6f27fd6b8029401c918f942253beb59b6a71ddf 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 336e91b10dc25d761dfc4389ac27d9ac324c52c0 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 
> 421b33023e3b443d579685f434a4e09957b1c6e0 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> f9fc6bcb7fdc2380043cf673a4002886192c20c1 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 
> 0c1b144bf22f1bf400da04bd5826a04891dfada2 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 08c4c2a4717a1c827f4cef6405d78e7db5046a00 
> 
> Diff: https://reviews.apache.org/r/18655/diff/
> 
> 
> Testing
> -------
> 
> /build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to