> On March 6, 2014, 12:43 a.m., David Robinson wrote:
> > I added the missing flag instead: https://reviews.apache.org/r/18746/
> > 
> > Would it be worthwhile exposing the feature as a flag in addition to a 
> > config option?
> 
> Brian Wickman wrote:
>     I'm not sure the flag makes sense for the restart command, since it 
> doesn't support rollback, right?

Excellent point!


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18819/#review36306
-----------------------------------------------------------


On March 5, 2014, 11:20 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18819/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 11:20 p.m.)
> 
> 
> Review request for Aurora, David Robinson and Brian Wickman.
> 
> 
> Bugs: AURORA-247
>     https://issues.apache.org/jira/browse/AURORA-247
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing rollback_on_failure from restart options.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/updater_util.py 
> bbbd48411a036ab46e5c88087efadfdc467dacc9 
>   src/main/python/apache/aurora/client/commands/core.py 
> 7c3c5303201a73ac93cdeeea0fb9ba2574c70949 
>   src/test/python/apache/aurora/client/commands/test_restart.py 
> f281b3544dcc6b59d5dc44bc97b9910306c3a23e 
> 
> Diff: https://reviews.apache.org/r/18819/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to