-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/
-----------------------------------------------------------

(Updated March 7, 2014, 10:37 a.m.)


Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, 
and Brian Wickman.


Changes
-------

Addressed Maxim's suggestion, and added a mock_sleep assertion + TODO for 
possible refactoring via Kevin's suggestion


Bugs: AURORA-223
    https://issues.apache.org/jira/browse/AURORA-223


Repository: aurora


Description
-------

As always, feel free to tear it apart.

I plan to add tests for the other commands as well, but wanted to get this out 
sooner than later to ensure others agreed with my approach.


Diffs (updated)
-----

  src/main/python/apache/aurora/admin/BUILD 
480dad69d8122168a6b7222ef9df0eb689fae386 
  src/main/python/apache/aurora/admin/mesos_maintenance.py 
d8ffdec062db07ce82556fb38ff4a5eea7921953 
  src/main/python/apache/aurora/client/base.py 
c5c969f9641c8e0e1604648b1f9ed542ab59b7d0 
  src/main/python/apache/aurora/client/bin/BUILD 
dbabfd0e56288d04c399e20976ea6e0287112d91 
  src/main/python/apache/aurora/client/commands/BUILD 
14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0 
  src/main/python/apache/aurora/client/commands/admin.py 
40588e23f5082604af9f474e9cf6ab84663b8d67 
  src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION 
  src/test/python/apache/aurora/admin/BUILD 
258b1eb58a4eec1650bfd317823f76a30889f912 
  src/test/python/apache/aurora/admin/test_mesos_maintenance.py 
000fbe5a873669bf55a9110f1aa6f1d7c8350ef8 
  src/test/python/apache/aurora/client/commands/BUILD 
6d448d7320a78bf140873b743805846c179281a7 
  src/test/python/apache/aurora/client/commands/test_maintenance.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/18334/diff/


Testing
-------

./pants ./src/test/python/apache/aurora:all

particularly:

src.test.python.apache.aurora.client.commands.maintenance                       
.....   SUCCESS


Thanks,

Joe Smith

Reply via email to