----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18926/#review36583 -----------------------------------------------------------
Do you mind changing the summary of this review? Since that winds up in the commit log, a commit message of "Investigate adding" is less direct than "Add". build.gradle <https://reviews.apache.org/r/18926/#comment67591> Reason for the extra line break isn't obvious to me - drop? - Bill Farner On March 7, 2014, 10:47 p.m., Jake Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18926/ > ----------------------------------------------------------- > > (Updated March 7, 2014, 10:47 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-102 > https://issues.apache.org/jira/browse/AURORA-102 > > > Repository: aurora > > > Description > ------- > > Aurora-102: Investigate adding failOnVersionConfict() to scheduler build > > Adds resolution strategy to compile time to detect and fail if any dependency > versions have conflicts. > > > Diffs > ----- > > build.gradle 9b8827ea05932620ebac4929838c158e853d73ae > > Diff: https://reviews.apache.org/r/18926/diff/ > > > Testing > ------- > > ran local build with protobuf dependency set to 2.4.1 > > FAILURE: Build failed with an exception. > > * What went wrong: > Could not resolve all dependencies for configuration ':compile'. > > A conflict was found between the following modules: > - com.google.protobuf:protobuf-java:2.4.1 > - com.google.protobuf:protobuf-java:2.5.0 > > > changed to version 2.5.0 > > BUILD SUCCESSFUL > > > Thanks, > > Jake Farrell > >