----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19143/#review36996 -----------------------------------------------------------
src/main/python/apache/aurora/client/api/scheduler_client.py <https://reviews.apache.org/r/19143/#comment68245> I'm pretty wary of swallowing exceptions like this - seems like an easy way to paper over bugs / hide truly exceptional events. I'd at least log the traceback at debug level here so that it's available in debug output. - Kevin Sweeney On March 12, 2014, 12:57 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19143/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 12:57 p.m.) > > > Review request for Aurora, Kevin Sweeney and Brian Wickman. > > > Bugs: aurora-259 > https://issues.apache.org/jira/browse/aurora-259 > > > Repository: aurora > > > Description > ------- > > Catch errors thrown by authentication modules. > > Authentication modules can throw arbitrary errors - ldap exceptions, > password errors, etc, if auth fails with one of these app specific > errors, the client current dumps its cookies in a stack dump. This > change catches the error cleanly, and transforms it into a handled > authentication exception. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/scheduler_client.py > f770df7a23779f919cd11cc28b2aaf7cfdf9c5a1 > > Diff: https://reviews.apache.org/r/19143/diff/ > > > Testing > ------- > > > Thanks, > > Mark Chu-Carroll > >
