-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18487/
-----------------------------------------------------------

(Updated March 14, 2014, 11:24 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Repository: aurora


Description
-------

There are a few nice things falling out of this refactor:
- New methods on mutable store interfaces are not implicitly forwarded
  (ForwardingStore does not implement mutable stores).
- Write ahead/behind behavior is more obvious in LogStorage
  (i found the delegation by calling super tough to catch mistakes.)
- Callers with a handle on LogStorage don't have a means to invoke mutate calls 
outside of a transaction
  (they only get access to mutable stores in write(), which obviated 
testMutateRequiresWriteOperation)


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
8758eb7f2d80b88bc13d42fa62021c255a54fdc8 
  src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 
3d0ff2dfc01404c890dc17d23c3d15732915c438 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
3ccf800a14cb987b798bc28d15dcbef50b4c78e7 
  src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
8b26cc0ac2a2a1be6e4cde91b3f84ae00ec98d29 

Diff: https://reviews.apache.org/r/18487/diff/


Testing
-------

./gradlew build


Thanks,

Bill Farner

Reply via email to