> On March 15, 2014, 1:40 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java, 
> > line 90
> > <https://reviews.apache.org/r/19250/diff/1/?file=520227#file520227line90>
> >
> >     Any chance this could be merged with the next statement?

It could, but i broke it up for readability.  LMK if you have any ideas for 
nesting it without making it harder to grok.


> On March 15, 2014, 1:40 a.m., Maxim Khutornenko wrote:
> > src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java,
> >  line 473
> > <https://reviews.apache.org/r/19250/diff/1/?file=520229#file520229line473>
> >
> >     Add checks for 1.6 and 1.7?

Sure, done.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19250/#review37310
-----------------------------------------------------------


On March 15, 2014, 1:16 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19250/
> -----------------------------------------------------------
> 
> (Updated March 15, 2014, 1:16 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-264
>     https://issues.apache.org/jira/browse/AURORA-264
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Properly handle filtering offers when multiple attributes have the same name.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 
> 5f1e4313d542410ded488c50ce8a714fcff73392 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
> 2360b1a51991dfe1b5dc241956bc65a9dab8e5ba 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> f6c444d27771f590c071cc14e9a050e31a46bd68 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  79d14c9460de405c5cb3f1c257c5bc264b4da421 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 8b6f0a1a728cb3b2e0b0d9acb55aee2dff460662 
> 
> Diff: https://reviews.apache.org/r/19250/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to