-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19450/#review37929
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronPredictor.java
<https://reviews.apache.org/r/19450/#comment69734>

    revert



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/19450/#comment69735>

    no need to abbreviate here



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
<https://reviews.apache.org/r/19450/#comment69740>

    Please use a mock here.



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
<https://reviews.apache.org/r/19450/#comment69741>

    +1 to mock.



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
<https://reviews.apache.org/r/19450/#comment69744>

    Assert a mocked value here instead.



src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java
<https://reviews.apache.org/r/19450/#comment69745>

    Mock here. In general prefer to avoid importing production classes across 
packages in unit tests



src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java
<https://reviews.apache.org/r/19450/#comment69746>

    +1 to mock


- Kevin Sweeney


On March 19, 2014, 11:22 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19450/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 11:22 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-277
>     https://issues.apache.org/jira/browse/AURORA-277
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added nextCronRunMs field to JobSummary.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronPredictor.java 
> 7b25152c0258e10be21b801cae1444c518367fa7 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  0d1e2147ce6a370962dab93383d52ddeba68efb5 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> e64f844cbd58d92621c6c21b896a9baf0c5a5f07 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  60df209150f29e2658c47d81042bd36c57d5afef 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> e78ee7b8051bc080dbb3ed2daf72171bffe3915a 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 456634c76b9993119af2d841073c31a4a1c82ab7 
> 
> Diff: https://reviews.apache.org/r/19450/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Reply via email to