> On March 20, 2014, 2:27 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/cli/jobs.py, line 293
> > <https://reviews.apache.org/r/19431/diff/1/?file=528673#file528673line293>
> >
> >     The "instance" syntax is mandatory for commands that can operate on 
> > instances. The parser is shared between all of them.
> >     
> >     For restart, run, and update, it make sense to be able to say "all 
> > shard". So you can say "all" instead of providing a numeric range.
> >     
> >     For kill, we don't want to allow users to specify "all"; we wnt them to 
> > use killall.
> >
> 
> Bill Farner wrote:
>     I know wickman has mentioned using * for this, which i personally find 
> more natural.  At the very least, this deserves some comments explaining the 
> methodology, as well as docs in the help output.  Ideally the doc for 
> developers would live near a constant that defines the wildcard string.

You're absolutely right about the documentation. I'll fix that.

Two objections to '*':
- * looks too much like we're allowing globbing. We're already using 
globbing/wildcards other place in the client, and the semantics are different. 
I think it's confusing that at other places in the client I can say 
"cluster/name/env/j*" to mean "all jobs that start with j", but here, '1*' 
wouldn't work. 
- If you use *, then the instance spec argument needs to be single-quoted in 
the shell.

The first is more serious to me. I think that that's a semantic distinction 
which should be clearly visible in the syntax.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19431/#review37933
-----------------------------------------------------------


On March 19, 2014, 7:38 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19431/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 7:38 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: aurora-268
>     https://issues.apache.org/jira/browse/aurora-268
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add instance specifier syntax to commands that can specify instances for 
> clientv2.
> 
> Also, while I was at it, I added the kill/killall distinction to clientv2.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 2e62519a0531b2c910bc2c0227fd835baee644f1 
>   src/main/python/apache/aurora/client/cli/options.py 
> 0e0bd45f9506e5dc729a24cd68b04b49650605b6 
>   src/main/python/apache/aurora/client/cli/task.py 
> 8d4d38efbd126911f46bc3f8944e81bc9d149e32 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> aa23d5bfe81361243d82aadf9dc574608e28d953 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 51858b9e4ca02c2ae2151275fff9936460936bb4 
> 
> Diff: https://reviews.apache.org/r/19431/diff/
> 
> 
> Testing
> -------
> 
> [sun-wukong incubator-aurora (instance-syntax)]$ !./p
> ./pants src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
> 
> =========================== 4 passed in 0.02 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .....
> 
> =========================== 5 passed in 0.48 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> ========================== 27 passed in 1.63 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
> 
> =========================== 2 passed in 0.49 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_quota.py ...
> 
> =========================== 3 passed in 0.50 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> 
> =========================== 5 passed in 0.53 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> =========================== 2 passed in 0.50 seconds 
> ===========================
> src.test.python.apache.aurora.client.cli.bridge                               
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.help                                 
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.job                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.plugins                              
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.quota                                
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.sla                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.task                                 
>   .....   SUCCESS
> [sun-wukong incubator-aurora (instance-syntax)]$
> [sun-wukong incubator-aurora (instance-syntax)]$ grep INSTANCES_OPTION 
> src/main/python/apache/aurora/client/cli/*.py
> src/main/python/apache/aurora/client/cli/options.py:INSTANCES_OPTION = 
> CommandOption('--instances', type=parse_instances, dest='instances',
> src/main/python/apache/aurora/client/cli/task.py:    INSTANCES_OPTION,
> [sun-wukong incubator-aurora (instance-syntax)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
> 
> =========================== 4 passed in 0.02 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .....
> 
> =========================== 5 passed in 0.47 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> ========================== 27 passed in 1.65 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
> 
> =========================== 2 passed in 0.51 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_quota.py ...
> 
> =========================== 3 passed in 0.49 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> 
> =========================== 5 passed in 0.53 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> =========================== 2 passed in 0.53 seconds 
> ===========================
> src.test.python.apache.aurora.client.cli.bridge                               
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.help                                 
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.job                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.plugins                              
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.quota                                
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.sla                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.task                                 
>   .....   SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to