> On March 20, 2014, 9:16 p.m., Maxim Khutornenko wrote:
> > I think this still needs some fine tuning. For example: ship-it should 
> > clear all previous comments from the reviewer and expose other required 
> > reviewers who did not post any comments yet. As it stands now neither of my 
> > RBs below show correct status:
> > 2014-03-20T00:26:09Z        https://reviews.apache.org/r/19436/     maxim   
> >         Preserving sandbo...    awaiting updated diff
> > 2014-03-20T18:04:39Z        https://reviews.apache.org/r/19243/     maxim   
> >         Adding min retent...    awaiting updated diff
> > 
> > Both got ship-its from one reviewer and no comments from the other.

Thanks for the examples, i'll fix this.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19494/#review37975
-----------------------------------------------------------


On March 20, 2014, 9:04 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19494/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 9:04 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Suman Karumuri, and Maxim 
> Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The tool now displays information about all outstanding reviews for the 
> project, ordered by staleness.  The first column in the 'outstanding' group 
> is the date of the last activity.
> 
> 
> Diffs
> -----
> 
>   build-support/tools/list-missing-shipits 
> 69225732eeced6e2a41bda5e675e6f109e041656 
> 
> Diff: https://reviews.apache.org/r/19494/diff/
> 
> 
> Testing
> -------
> 
> 2014-01-15T03:12:01Z  https://reviews.apache.org/r/16710/     kevints         
> Support multiple ...    awaiting updated diff
> 2014-02-21T15:07:51Z  https://reviews.apache.org/r/16144/     jcohen          
> ZookeeperSchedule...    awaiting updated diff
> 2014-02-26T00:19:41Z  https://reviews.apache.org/r/18490/     kevints         
> Generate cron pre...    awaiting updated diff
> 2014-02-27T23:17:03Z  https://reviews.apache.org/r/16062/     drobinson       
> fixed structdump ...    ready to submit
> 2014-03-04T19:53:25Z  https://reviews.apache.org/r/18746/     drobinson       
> fix rollback on f...    need review from wickman
> 2014-03-10T23:29:08Z  https://reviews.apache.org/r/18537/     protochron      
> AURORA-227: Auror...    need review from wickman
> 2014-03-11T16:33:19Z  https://reviews.apache.org/r/18996/     markcc          
> Fix errors in job...    awaiting updated diff
> 2014-03-11T23:07:33Z  https://reviews.apache.org/r/19063/     atollena        
> Fix help usage fo...    awaiting updated diff
> 2014-03-12T22:51:58Z  https://reviews.apache.org/r/18979/     markcc          
> Add an updated ve...    awaiting updated diff
> 2014-03-13T22:45:34Z  https://reviews.apache.org/r/19207/     tgalloway       
> Removed content a...    need review from clambert, davelester, wickman
> 2014-03-17T17:33:34Z  https://reviews.apache.org/r/19143/     markcc          
> Catch errors thro...    awaiting updated diff
> 2014-03-17T18:57:57Z  https://reviews.apache.org/r/19313/     tgalloway       
> added killall com...    need review from clambert, markcc, davelester
> 2014-03-18T18:15:24Z  https://reviews.apache.org/r/19362/     maxim           
> Changing from STA...    need review from wickman
> 2014-03-19T13:12:55Z  https://reviews.apache.org/r/19396/     markcc          
> Implement client ...    need review from kevints, wickman
> 2014-03-20T00:00:49Z  https://reviews.apache.org/r/19426/     wickman         
> Don't forget to r...    awaiting updated diff
> 2014-03-20T00:26:09Z  https://reviews.apache.org/r/19436/     maxim           
> Preserving sandbo...    awaiting updated diff
> 2014-03-20T13:27:36Z  https://reviews.apache.org/r/19411/     markcc          
> Add support for g...    need review from maxim, wickman
> 2014-03-20T15:37:08Z  https://reviews.apache.org/r/19466/     markcc          
> Add batching to t...    need review from maxim, wickman
> 2014-03-20T16:19:12Z  https://reviews.apache.org/r/19462/     dam_ned         
> [AURORA-282] add ...    awaiting updated diff
> 2014-03-20T18:04:39Z  https://reviews.apache.org/r/19243/     maxim           
> Adding min retent...    awaiting updated diff
> 2014-03-20T18:16:05Z  https://reviews.apache.org/r/19450/     mansu           
> Added nextCronRun...    awaiting updated diff
> 2014-03-20T18:20:38Z  https://reviews.apache.org/r/19078/     maxim           
> Part 2 of convert...    awaiting updated diff
> 2014-03-20T18:29:24Z  https://reviews.apache.org/r/18658/     kevints         
> GZIP HTTP thrift ...    need review from wfarner, mansu
> 2014-03-20T18:41:53Z  https://reviews.apache.org/r/18714/     wfarner         
> Disable log and i...    awaiting updated diff
> 2014-03-20T18:47:00Z  https://reviews.apache.org/r/19431/     markcc          
> Add instance spec...    need review from wfarner, wickman
> 
> Recently submitted: 1
> https://reviews.apache.org/r/18580/   kevints Upgrade mesos to ...
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to