-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19396/
-----------------------------------------------------------

(Updated March 21, 2014, 3:06 p.m.)


Review request for Aurora, Kevin Sweeney and Brian Wickman.


Changes
-------

Address Brian's review comments:
- move default print_out and print_err implementations into the context 
superclass.
- add some explanatory text to the logging function docs.


Bugs: aurora-276
    https://issues.apache.org/jira/browse/aurora-276


Repository: aurora


Description
-------

Adding a centralized logger interface for clientv2.

For the aurora analytics work, we need some hooks for logging. We'd like all 
client logging to go through a common interface, and for client logs that might 
be sent to the centralized logging service to be tagged with identifiers and 
userids.

This change implements a simple minimal logging function that's used by 
clientv2 logging calls, and which attaches a universally unique client 
identifier to each log message.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/__init__.py 
4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0 
  src/main/python/apache/aurora/client/cli/context.py 
dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe 
  src/main/python/apache/aurora/client/cli/jobs.py 
2e62519a0531b2c910bc2c0227fd835baee644f1 
  src/test/python/apache/aurora/client/cli/BUILD 
a48284c8cffa64b56760f8e0c587506caf1289a6 
  src/test/python/apache/aurora/client/cli/test_logging.py PRE-CREATION 

Diff: https://reviews.apache.org/r/19396/diff/


Testing
-------

============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/test_binding_helper.py ..

=========================== 2 passed in 0.37 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/test_config.py ......

=========================== 6 passed in 0.46 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_disambiguator.py ......

=========================== 6 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/api/test_job_monitor.py .

=========================== 1 passed in 0.39 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_restarter.py ......

=========================== 6 passed in 0.36 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 47 items / 1 skipped

src/test/python/apache/aurora/client/api/test_scheduler_client.py 
...............................................

===================== 47 passed, 1 skipped in 3.59 seconds =====================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 20 items

src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
src/test/python/apache/aurora/client/api/test_health_check.py ............

========================== 20 passed in 0.25 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items

src/test/python/apache/aurora/client/api/test_updater.py 
...........................

========================== 27 passed in 0.64 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_quota_check.py ......

=========================== 6 passed in 0.15 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items

src/test/python/apache/aurora/client/api/test_sla.py ...........................

========================== 27 passed in 0.32 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py ....

=========================== 4 passed in 0.02 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .....

=========================== 5 passed in 0.59 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .....
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py .......
src/test/python/apache/aurora/client/cli/test_update.py ...

========================== 27 passed in 1.79 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=========================== 1 passed in 0.54 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/cli/test_plugins.py ..

=========================== 2 passed in 0.53 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items

src/test/python/apache/aurora/client/cli/test_quota.py ...

=========================== 3 passed in 0.53 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items

src/test/python/apache/aurora/client/cli/test_sla.py .....

=========================== 5 passed in 0.53 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/cli/test_task_run.py ..

=========================== 2 passed in 0.50 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 13 items

src/test/python/apache/aurora/client/commands/test_admin_sla.py .............

========================== 13 passed in 0.46 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items

src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ...
src/test/python/apache/aurora/client/commands/test_update.py ...

========================== 26 passed in 1.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/commands/test_maintenance.py ....

=========================== 4 passed in 0.43 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_run.py .

=========================== 1 passed in 0.46 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_ssh.py .

=========================== 1 passed in 0.44 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 12 items

src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............

========================== 12 passed in 0.49 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....

=========================== 4 passed in 0.42 seconds ===========================
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
src.test.python.apache.aurora.client.api.disambiguator                          
.....   SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher                       
.....   SUCCESS
src.test.python.apache.aurora.client.api.job_monitor                            
.....   SUCCESS
src.test.python.apache.aurora.client.api.quota_check                            
.....   SUCCESS
src.test.python.apache.aurora.client.api.restarter                              
.....   SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client                       
.....   SUCCESS
src.test.python.apache.aurora.client.api.sla                                    
.....   SUCCESS
src.test.python.apache.aurora.client.api.updater                                
.....   SUCCESS
src.test.python.apache.aurora.client.binding_helper                             
.....   SUCCESS
src.test.python.apache.aurora.client.cli.bridge                                 
.....   SUCCESS
src.test.python.apache.aurora.client.cli.help                                   
.....   SUCCESS
src.test.python.apache.aurora.client.cli.job                                    
.....   SUCCESS
src.test.python.apache.aurora.client.cli.logging                                
.....   SUCCESS
src.test.python.apache.aurora.client.cli.plugins                                
.....   SUCCESS
src.test.python.apache.aurora.client.cli.quota                                  
.....   SUCCESS
src.test.python.apache.aurora.client.cli.sla                                    
.....   SUCCESS
src.test.python.apache.aurora.client.cli.task                                   
.....   SUCCESS
src.test.python.apache.aurora.client.commands.admin                             
.....   SUCCESS
src.test.python.apache.aurora.client.commands.core                              
.....   SUCCESS
src.test.python.apache.aurora.client.commands.maintenance                       
.....   SUCCESS
src.test.python.apache.aurora.client.commands.run                               
.....   SUCCESS
src.test.python.apache.aurora.client.commands.ssh                               
.....   SUCCESS
src.test.python.apache.aurora.client.config                                     
.....   SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api                           
.....   SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api                       
.....   SUCCESS


Thanks,

Mark Chu-Carroll

Reply via email to