-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19436/#review38240
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java
<https://reviews.apache.org/r/19436/#comment70296>

    Actually, both previousState and the previousState.getStatus() could be 
nulls here. Converted previousState to Optional to avoid relying on internal 
logic (i.e. previousState.getStatus() should NOT return null under normal 
conditions) and return null if either previousState is null or 
previousState.getStatus() is null.


- Maxim Khutornenko


On March 21, 2014, 7:42 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19436/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 7:42 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-261
>     https://issues.apache.org/jira/browse/AURORA-261
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Part 1: Introducing TaskState internal enum facilitate task deletion coming 
> next.
> 
> The only functional change in this CR is dropping 
> TaskStateMachine.getState(). Rest is ScheduleStatus to TaskState conversion.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 7371c12eb1efc3686582fdbbcb5e3b404bac61a6 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 15d1c1f5c2dc8161d9a203a98e4c40b123b93938 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> 77380d9aaab99a9ad739bbc22251232354133c8d 
> 
> Diff: https://reviews.apache.org/r/19436/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to