----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19710/#review38758 -----------------------------------------------------------
build-support/release/changelog <https://reviews.apache.org/r/19710/#comment71030> Can you include a usage preamble, along with concise prose about what this does? build-support/release/changelog <https://reviews.apache.org/r/19710/#comment71037> Please wrap at 100 cols. Perhaps stating the obvious, but for others - we'll need to go back and tag fixVersion on tickets to make this first release changelog accurate. build-support/release/release <https://reviews.apache.org/r/19710/#comment71029> consider adding: set -o nounset build-support/release/release <https://reviews.apache.org/r/19710/#comment71040> Mind using single quotes for strings you don't intend to interpolate? build-support/release/release <https://reviews.apache.org/r/19710/#comment71042> I don't feel too strongly on this, but i've ~completely replaced my use of backticks with $(). Some reasoning matches this SO answer: http://stackoverflow.com/questions/9405478/command-substitution-backticks-or-dollar-sign-paren-enclosed build-support/release/release-candidate <https://reviews.apache.org/r/19710/#comment71031> How would you feel about inverse behavior here - dry run by default? I'm not firm on this, but i tend to like it for scripts that you might be embarrassed by accidentally invoking. docs/committers.md <https://reviews.apache.org/r/19710/#comment71035> Trim this to match the heading text. docs/committers.md <https://reviews.apache.org/r/19710/#comment71032> trailing whitespace, here and below docs/committers.md <https://reviews.apache.org/r/19710/#comment71033> Please wrap at 100 cols, here and below - Bill Farner On March 27, 2014, 3:24 a.m., Jake Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19710/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 3:24 a.m.) > > > Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-78 > https://issues.apache.org/jira/browse/AURORA-78 > > > Repository: aurora > > > Description > ------- > > AURORA-78: automate and enforce release workflow > > Adds scripts to generate the CHANGELOG from JIRA, create the > release candidate, generate the release candidate VOTE email draft, > generate the release from the release candidate and the RESULT VOTE > email draft. docs/committers.md added with process flow details. > > > Diffs > ----- > > CHANGELOG PRE-CREATION > build-support/release/changelog PRE-CREATION > build-support/release/release PRE-CREATION > build-support/release/release-candidate PRE-CREATION > build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b > docs/committers.md PRE-CREATION > docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 > > Diff: https://reviews.apache.org/r/19710/diff/ > > > Testing > ------- > > > Thanks, > > Jake Farrell > >
