-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19709/#review38799
-----------------------------------------------------------



build.gradle
<https://reviews.apache.org/r/19709/#comment71109>

    What would it take to do that now?  Is it as simple as System.setProperty?



src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java
<https://reviews.apache.org/r/19709/#comment71112>

    doc?



src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java
<https://reviews.apache.org/r/19709/#comment71113>

    doc?



src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java
<https://reviews.apache.org/r/19709/#comment71114>

    Do these all need to be public?  Looks like most of these accessors are 
only used within this class.
    
    Many others seem like they should be @VisibleTesting as well.



src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java
<https://reviews.apache.org/r/19709/#comment71115>

    s/SINGLETON/INT/?



src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java
<https://reviews.apache.org/r/19709/#comment71117>

    replaceNameAliases?


- Bill Farner


On March 27, 2014, 1:37 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19709/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 1:37 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-132
>     https://issues.apache.org/jira/browse/AURORA-132
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Cron scheduler based on Quartz.
> 
> Apologies for the monster diff - I will try to split it but wanted to give 
> y'all a chance to take a look in the evening/morning.
> 
> I'd suggest reviewing CrontabEntry and CrontabEntryTest for now - the rest is 
> plumbing.
> 
> 
> Diffs
> -----
> 
>   build.gradle c2a70b0285c6afb20f6db387e50744424c572d3f 
>   src/main/java/org/apache/aurora/scheduler/cron/CronPredictor.java 
> df0c37839c5da54795404c18ff9fc93084cd32e4 
>   src/main/java/org/apache/aurora/scheduler/cron/CronScheduler.java 
> 56e9950fd94ae1e3dbd96baec00b7e6b262fbe34 
>   src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/cron/CrontabEntryTest.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronPredictor.java 
> 7b25152c0258e10be21b801cae1444c518367fa7 
>   src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronScheduler.java 
> a31551c77818c17ee0f9f71b5ab458a3b853dc6a 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronExpressions.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronModule.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronPredictor.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronScheduler.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java 
> 61b01d2575d6cfce069e77c39bfa8f8680cf4298 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 
> e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
>   src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 
> 70ccf036c0676accd4a60c91bac1e6c77f365598 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  12d33ffa0fc246d50ed95bb2399af9707087d068 
>   
> src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json
>  dced8b454c97b9c456605144161ff5c946cb384f 
>   src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 
> a9b85d0983dcfee89101a5e774ba86ee11708c68 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronIT.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronPredictorTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronSchedulerTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  033ebd29a4e95914347c1f5f8ade73115585a26f 
>   src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 
> 380df1011cec2970dbcf37252d469dc6373b66f6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c89965cee38a72b23fe65cb14bfa61b4cba0bfc4 
> 
> Diff: https://reviews.apache.org/r/19709/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> Removed a few test cases from valid-cron-schedules.json after inspection 
> revealed they should be considered invalid.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to