-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19808/#review39078
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java
<https://reviews.apache.org/r/19808/#comment71465>

    Can we change this to use an iterable?


- Suman Karumuri


On March 28, 2014, 9:51 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19808/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 9:51 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Suman Karumuri.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This removes a circular dependency between CronJobManager and 
> SchedulerCoreImpl.  There are some minor cleanups to CronJobManager that i've 
> made along the way.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 
> 70ccf036c0676accd4a60c91bac1e6c77f365598 
>   src/main/java/org/apache/aurora/scheduler/state/ImmediateJobManager.java 
> dc18b5be337cf7383734fc1ef76203c6d52886e3 
>   src/main/java/org/apache/aurora/scheduler/state/JobManager.java 
> 8dba0a71c33ed58a2c7be00a26d88178c5901434 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> 7a13a8b9e8c9b7a767ec4bc4201e97de17809b82 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 3ca4ee529aaf3491118da216116b19d7c6a49d09 
>   src/main/java/org/apache/aurora/scheduler/state/StateModule.java 
> 4f0bbfa9284bfe62d1a8f9cecedb01a79c6014fc 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  12d33ffa0fc246d50ed95bb2399af9707087d068 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  033ebd29a4e95914347c1f5f8ade73115585a26f 
>   src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 
> 380df1011cec2970dbcf37252d469dc6373b66f6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c89965cee38a72b23fe65cb14bfa61b4cba0bfc4 
> 
> Diff: https://reviews.apache.org/r/19808/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to