----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20046/#review39581 -----------------------------------------------------------
src/test/python/apache/aurora/common/test_shellify.py <https://reviews.apache.org/r/20046/#comment72004> How about adding test values/strings with: ", ', \ (backslash), !, $, (, ), `, and ~ in as well. src/test/python/apache/aurora/common/test_shellify.py <https://reviews.apache.org/r/20046/#comment72005> Trailing space. - Tobias Weingartner On April 4, 2014, 7:21 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20046/ > ----------------------------------------------------------- > > (Updated April 4, 2014, 7:21 p.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Repository: aurora > > > Description > ------- > > Add a new subcommand to aurora_admin to dump cluster state as a shell script. > > Useful to allow you to write shell scripts with the current cluster settings > without needing to duplicate information. > > > Diffs > ----- > > src/main/python/apache/aurora/client/commands/admin.py > 2b37101ac4983300318db2d1e913782637019dec > src/main/python/apache/aurora/common/BUILD > 5d1cfe0735a5d973234115e7f99556312f004427 > src/main/python/apache/aurora/common/shellify.py PRE-CREATION > src/test/python/apache/aurora/common/BUILD > 2d9ba67e1ec94d61297dab16f2a78ba2ef6e8d2d > src/test/python/apache/aurora/common/test_shellify.py PRE-CREATION > > Diff: https://reviews.apache.org/r/20046/diff/ > > > Testing > ------- > > ./pants src/test/python:all > > % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin > dump_cluster_context --sh devcluster > AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest > AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED > AURORA_CLUSTER_NAME=devcluster > AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos > AURORA_CLUSTER_ZK=192.168.33.7 > AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler > > % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin > dump_cluster_context --sh --export devcluster > export AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest > export AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED > export AURORA_CLUSTER_NAME=devcluster > export AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos > export AURORA_CLUSTER_ZK=192.168.33.7 > export AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler > > % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin > dump_cluster_context devcluster > {"slave_run_directory": "latest", "auth_mechanism": "UNAUTHENTICATED", > "name": "devcluster", "slave_root": "/var/lib/mesos", "zk": "192.168.33.7", > "scheduler_zk_path": "/aurora/scheduler"} > > > Thanks, > > Kevin Sweeney > >
