> On April 9, 2014, 10:23 p.m., Kevin Sweeney wrote:
> > Executors aren't meant to be invoked directly - they're invoked by the 
> > mesos-slave with some special environment variables. So they're more akin 
> > to "libexec" files. The observer is standalone though and can be moved.

Aha, I see. I will submit an updated patch. Is it appropriate to also change 
the Summary of this review request to reflect the change? Something like "Put 
Thermos observer in default path for Vagrant example"?


- Johan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20174/#review39928
-----------------------------------------------------------


On April 9, 2014, 10:11 p.m., Johan Liseborn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20174/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 10:11 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> It seems thermos_observer, thermos_executor, and gc_executor did not get 
> copied or linked to somewhere in the default PATH after the refactor to only 
> one instance under Vagrant. This resulted in 
> /etc/init/aurora-thermos-observer.conf to fail, and thermos_observer where 
> not started.
> 
> I am unsure where the proper place to link is, but I tried to mimic the 
> structure from before the refactor, i.e. link them under /usr/local/bin (and 
> updated the run script accordingly).
> 
> Also note that I am not terribly familiar with Aurora, so there may be things 
> I have misunderstood. The only thing I noticed was the thermos_observer did 
> not start automatically, and this seems to be fixed by the patch.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/provision-dev-cluster.sh 
> ec9554356cd789d308a5adce4784b04abe64ab95 
>   examples/vagrant/upstart/aurora-thermos-observer.conf 
> 6db85aad5b0c2d484656bfb5d5bfa4ad4c9b3342 
> 
> Diff: https://reviews.apache.org/r/20174/diff/
> 
> 
> Testing
> -------
> 
> I have tested the patch using Vagrant on OS X 10.9.2, and it seems to work as 
> intended.
> 
> 
> Thanks,
> 
> Johan Liseborn
> 
>

Reply via email to