-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20238/#review40116
-----------------------------------------------------------



build.gradle
<https://reviews.apache.org/r/20238/#comment72976>

    I had a slightly different approach to this that automated the 
bootstrapThrift check and usage that did not depend on a flag. put up as a 
separate review so we could compare notes
    
    https://reviews.apache.org/r/20246/



examples/vagrant/provision-dev-cluster.sh
<https://reviews.apache.org/r/20238/#comment72974>

    could put this into the Aurora svn and pull from there or use this path 
until I can get Thrift into a more standard install location



examples/vagrant/provision-dev-cluster.sh
<https://reviews.apache.org/r/20238/#comment72975>

    I dont think that we need this flag, have a slightly different patch for 
build.gradle which automates the check and building of Thrift, will throw it up 
for review


- Jake Farrell


On April 10, 2014, 10:44 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20238/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 10:44 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-299
>     https://issues.apache.org/jira/browse/AURORA-299
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Optionally use system-installed thrift in build.gradle, use this in vagrant 
> devcluster.
> 
> 
> Diffs
> -----
> 
>   build.gradle cdcc0158079bc91b5c10fad4e7c80d2f98da227f 
>   docs/tutorial.md 64981a7a4cef35036ad660142fe15fd95e1b6068 
>   examples/vagrant/provision-dev-cluster.sh 
> ec9554356cd789d308a5adce4784b04abe64ab95 
> 
> Diff: https://reviews.apache.org/r/20238/diff/
> 
> 
> Testing
> -------
> 
> $ time vagrant up
> ...
> real  13m59.641s
> user  0m16.606s
> sys   0m5.275s
> 
> (Previously this was ~20 min on my 2011 macbook air.)
> 
> $ sh examples/vagrant/test_tutorial.sh
> Checking scheduler health...PASS
> Checking observer health...PASS
> Checking master health...PASS
> Checking slave health...PASS
> Running create command...PASS
> Waiting to observe FAILED task...PASS
> Running update command...PASS
> Waiting to observe RUNNING task...PASS
> Running killall command...PASS
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to