-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20490/#review40818
-----------------------------------------------------------

Ship it!



src/main/python/apache/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/20490/#comment73989>

    Mind using 4 tabs here or aligning with previous?


- Maxim Khutornenko


On April 18, 2014, 5:30 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20490/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 5:30 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a "get version" API method. (This is needed for a logging-related change 
> for twitter.)
> 
> While I'm in there, fix a bug in "job list".
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0793a1ae4bd5d641ea57473705076290d77ac2b6 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 6876bb78b15a676fb2eb8964a55c60d9bbdb4be7 
> 
> Diff: https://reviews.apache.org/r/20490/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/test_binding_helper.py ..
> 
> ========================================== 2 passed in 0.39 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/test_config.py ......
> 
> ========================================== 6 passed in 0.47 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
> 
> ========================================== 6 passed in 0.46 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
> 
> ========================================== 1 passed in 0.41 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_restarter.py ......
> 
> ========================================== 6 passed in 0.36 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
> 
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ...............................................
> 
> ==================================== 47 passed, 1 skipped in 3.83 seconds 
> ====================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
> 
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
> 
> ========================================= 20 passed in 0.24 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
> 
> src/test/python/apache/aurora/client/api/test_updater.py 
> ...........................
> 
> ========================================= 27 passed in 0.64 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
> 
> ========================================== 6 passed in 0.15 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 31 items
> 
> src/test/python/apache/aurora/client/api/test_sla.py 
> ...............................
> 
> ========================================= 31 passed in 0.26 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
> 
> ========================================== 4 passed in 0.03 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .....
> 
> ========================================== 5 passed in 0.51 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .........
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> ========================================= 36 passed in 1.83 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> ========================================== 1 passed in 0.54 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
> 
> ========================================== 2 passed in 0.52 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_quota.py ....
> 
> ========================================== 4 passed in 0.54 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> 
> ========================================== 5 passed in 0.56 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> ========================================== 2 passed in 0.56 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
> 
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
> 
> ========================================= 13 passed in 0.49 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
> 
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
> 
> ========================================= 26 passed in 1.31 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
> 
> src/test/python/apache/aurora/client/commands/test_hooks.py ...
> 
> ========================================== 3 passed in 1.14 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/commands/test_maintenance.py ....
> 
> ========================================== 4 passed in 0.46 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/commands/test_run.py .
> 
> ========================================== 1 passed in 0.49 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/commands/test_ssh.py .
> 
> ========================================== 1 passed in 0.46 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 12 items
> 
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
> 
> ========================================= 12 passed in 0.65 seconds 
> ==========================================
> ============================================ test session starts 
> =============================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
> 
> ========================================== 4 passed in 0.43 seconds 
> ==========================================
> src.test.python.apache.aurora.client.api.disambiguator                        
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher                     
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor                          
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.quota_check                          
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.restarter                            
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client                     
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.sla                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.updater                              
>   .....   SUCCESS
> src.test.python.apache.aurora.client.binding_helper                           
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.bridge                               
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.help                                 
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.job                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.logging                              
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.plugins                              
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.quota                                
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.sla                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.task                                 
>   .....   SUCCESS
> src.test.python.apache.aurora.client.commands.admin                           
>   .....   SUCCESS
> src.test.python.apache.aurora.client.commands.core                            
>   .....   SUCCESS
> src.test.python.apache.aurora.client.commands.hooks                           
>   .....   SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance                     
>   .....   SUCCESS
> src.test.python.apache.aurora.client.commands.run                             
>   .....   SUCCESS
> src.test.python.apache.aurora.client.commands.ssh                             
>   .....   SUCCESS
> src.test.python.apache.aurora.client.config                                   
>   .....   SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api                         
>   .....   SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api                     
>   .....   SUCCESS
> [sun-wukong incubator-aurora (get_version)]$
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to