-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18979/#review40854
-----------------------------------------------------------


Whoa- awesome 


docs/clientv2.md
<https://reviews.apache.org/r/18979/#comment74096>

    (maybe instead remove one of the thats?) "The problem we're facing..."



docs/clientv2.md
<https://reviews.apache.org/r/18979/#comment74098>

    This section is a great summary of the issues, +1



docs/clientv2.md
<https://reviews.apache.org/r/18979/#comment74097>

    should this have a dash?



docs/clientv2.md
<https://reviews.apache.org/r/18979/#comment74099>

    oh man. didn't realize this was gonna be a part of this. _awesome_



docs/clientv2.md
<https://reviews.apache.org/r/18979/#comment74101>

    maybe include a note to mention killall?



docs/clientv2.md
<https://reviews.apache.org/r/18979/#comment74102>

    is there a way to configure/control/specify this process? (I don't recall 
if this uses UpdateConfig or not, happy to check then report back if you don't 
recall either)



docs/clientv2.md
<https://reviews.apache.org/r/18979/#comment74100>

    isn't cron the noun? Looks like it at both line 177 and 227, but I'm kinda 
confused by 228+229. If not, would appreciate some clarification if you don't 
mind



docs/clientv2.md
<https://reviews.apache.org/r/18979/#comment74103>

    looks like the indenting got a lil funky here



docs/clientv2.md
<https://reviews.apache.org/r/18979/#comment74104>

    hoorah!


- Joe Smith


On March 21, 2014, 10:58 a.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18979/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 10:58 a.m.)
> 
> 
> Review request for Aurora, Dave Lester and Tom Galloway.
> 
> 
> Bugs: aurora-253
>     https://issues.apache.org/jira/browse/aurora-253
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an updated version of the clientv2 doc to apache.
> 
> (Also make a few changes in the interfaces to match the updated doc.)
> 
> 
> Diffs
> -----
> 
>   docs/clientv2.md PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 3b327df5f9c5f1d5e7e68863191313921a8dde44 
> 
> Diff: https://reviews.apache.org/r/18979/diff/
> 
> 
> Testing
> -------
> 
> n/a
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to