-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20583/
-----------------------------------------------------------

Review request for Aurora, Kevin Sweeney and Bill Farner.


Repository: aurora


Description
-------

Pins twitter.common on 0.3.0 (save twitter.common.python which is released out 
of band.)
Upgrades aurora to twitter.pants 0.0.18 which uses twitter.common.python==0.5.1 
and produces wheels.
Updates the thrift python namespaces so that the autogenerated python artifacts 
do not clobber each other.


Diffs
-----

  3rdparty/python/BUILD 70fb09df4c78a5e22702c054dfe7270bd9636e0f 
  BUILD c075158c7104db84c9eacfd83262e8fd7f120a4c 
  pants 56847307fcffb244c1debb14f2250564a9174955 
  pants.ini 5e85d50bc488b2b153a437b946b425f2b512b30e 
  src/main/python/apache/aurora/admin/host_maintenance.py 
6a21ddeb4203a07a04360f68c4a338fe3da52c70 
  src/main/python/apache/aurora/client/api/__init__.py 
ecc3742411b9fed73d6e4cea43da1bc25e2ae97e 
  src/main/python/apache/aurora/client/api/command_runner.py 
f7605f40b5c4ec864a1bae68649f282268260528 
  src/main/python/apache/aurora/client/api/health_check.py 
de7dc69d798e2b90844e95501b4375f90f6e5f94 
  src/main/python/apache/aurora/client/api/instance_watcher.py 
d7db426e6ac712e69eb18a10b6e4cb2da4509aa9 
  src/main/python/apache/aurora/client/api/job_monitor.py 
537e417e074468e169062b73ab207331c51d6a30 
  src/main/python/apache/aurora/client/api/quota_check.py 
c58bc4bfac47f85f674af15845b06d9f2294fe57 
  src/main/python/apache/aurora/client/api/restarter.py 
d060c1b27af2864a33e6524e58b81fe767ec2e98 
  src/main/python/apache/aurora/client/api/scheduler_client.py 
d0e0821a8e8ad38302678ecf686a6028300ebe22 
  src/main/python/apache/aurora/client/api/sla.py 
c381de4f1c8eb289efedce9a4efe93d44f44ff62 
  src/main/python/apache/aurora/client/api/updater.py 
9739af025b810c48f10f65edc2c10da88a8b1a2a 
  src/main/python/apache/aurora/client/base.py 
a33e65ce2b455148d4944d20bbff638dfca7d34a 
  src/main/python/apache/aurora/client/cli/context.py 
83f7b6a4ae1e6896278752cb481901c6e381ba0e 
  src/main/python/apache/aurora/client/cli/jobs.py 
798f54deb35afb72cd3b8d3cb972d386e48d6c2e 
  src/main/python/apache/aurora/client/cli/quota.py 
80f7817890c383fec78811ece7d88e90829b067e 
  src/main/python/apache/aurora/client/cli/task.py 
e4ee77ede119fc1e3bd196293965073405bb48b3 
  src/main/python/apache/aurora/client/commands/admin.py 
2b37101ac4983300318db2d1e913782637019dec 
  src/main/python/apache/aurora/client/commands/core.py 
b1abc9e7b1923d2e56f452c6891ddaa959d95b40 
  src/main/python/apache/aurora/client/config.py 
855f7091837695658fbcd9003f7f85ee28aacde7 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 
48e85143040b41f9337fd562151665bc47bb714f 
  src/main/python/apache/aurora/common/aurora_job_key.py 
a0bc6e5674b6c91442b5619f2dd93afa1aa62e30 
  src/main/python/apache/aurora/common/auth/auth_module.py 
c055036ef2fcfa47fc7e592a284d1d83fe21dc8f 
  src/main/python/apache/aurora/common/auth/auth_module_manager.py 
53b2a3100a094905b3bf093dd7513aaceaadb074 
  src/main/python/apache/aurora/config/schema/base.py 
4a086b31802a0362a6855390dd0d5b431b3a9551 
  src/main/python/apache/aurora/config/thrift.py 
4cc0f0757df6cae387a1f2c293e361dac95e5914 
  src/main/python/apache/aurora/executor/common/task_info.py 
29a05be18febf1a75914b60bc84ad1bd3d629bb1 
  src/main/python/apache/aurora/executor/executor_vars.py 
f358fe5a220e57842f7fbf3d83ffeff35bc9a41e 
  src/main/python/apache/aurora/executor/gc_executor.py 
4a866b2d6041a592692812eb3472db744d21e194 
  src/main/python/apache/thermos/testing/runner.py 
0ef4cac3cfb16db91be2eac349852d989fdf4e3f 
  src/main/thrift/org/apache/aurora/gen/BUILD 
dce379cedc0fe025e59dbed6186f650a58bc42c2 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
c0618e4edebd6f282698abfd9bdc3c36fff16920 
  src/test/python/apache/aurora/admin/test_host_maintenance.py 
95497aea3d3f769b2460adbfe7a7b72d775ced6f 
  src/test/python/apache/aurora/client/api/test_disambiguator.py 
d964d9165190ebb86e3cd2a866f537c707456126 
  src/test/python/apache/aurora/client/api/test_health_check.py 
d503281ac492a72f49f17b48ba306bc2135f4d05 
  src/test/python/apache/aurora/client/api/test_instance_watcher.py 
f001ba45ca12332c9a2e18ff5348a0e6ce276926 
  src/test/python/apache/aurora/client/api/test_job_monitor.py 
4ab8a5d68f55c9ace7a9e845edcca5db08990e25 
  src/test/python/apache/aurora/client/api/test_quota_check.py 
b2598ad11f2f4bd5004c61742cc2ba4452e5fd0e 
  src/test/python/apache/aurora/client/api/test_restarter.py 
7a68a9748ce25c45dafc96b936e7c74c10467f9e 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
10c2a90f43fed80e35adbf3604e5655431c1299a 
  src/test/python/apache/aurora/client/api/test_sla.py 
dedc8f1f8c65aed36d89cfaa7cfe3c44df338e50 
  src/test/python/apache/aurora/client/api/test_updater.py 
a5680a0255f0077db90308ce87b70b1117e64df6 
  src/test/python/apache/aurora/client/cli/test_cancel_update.py 
2f86e2e817cf62e0c08697e611a2c202ac395b86 
  src/test/python/apache/aurora/client/cli/test_create.py 
6f8d91e9133587450bd911a3ba41e7fd680f84df 
  src/test/python/apache/aurora/client/cli/test_diff.py 
fbfd3ddd8cbfd3dce7d62cc634a1d0663251a93b 
  src/test/python/apache/aurora/client/cli/test_kill.py 
208816060789a49f6c6dc5d2081bab784a8c811d 
  src/test/python/apache/aurora/client/cli/test_logging.py 
b6241b8e1233c15993cf39331f25323298534dc4 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
7cacb02ffda05fdf87a9334ed1de2092efb39f8b 
  src/test/python/apache/aurora/client/cli/test_quota.py 
1bd432a0e89bae11640b5a88e86ea16d30d72065 
  src/test/python/apache/aurora/client/cli/test_restart.py 
834c60327c97a511205d23326f6a03f55fd710e9 
  src/test/python/apache/aurora/client/cli/test_status.py 
4813ce1913fdb23be01a5a394c69866ad029f7bd 
  src/test/python/apache/aurora/client/cli/test_task_run.py 
529fb404e2c283acacf3aec891d361813b80dc50 
  src/test/python/apache/aurora/client/cli/test_update.py 
e321b4cfcc31fed2428e7b635144cb6656a27e9d 
  src/test/python/apache/aurora/client/cli/util.py 
bc2a3e9b88947bb9ab06d945c0f154f3b19a9ff9 
  src/test/python/apache/aurora/client/commands/test_cancel_update.py 
da9ed2fc97dfa545ae5effbbd07dacd556b82a1e 
  src/test/python/apache/aurora/client/commands/test_create.py 
ceea25d3afcd1e609d1ba9dbc8933d78abee078b 
  src/test/python/apache/aurora/client/commands/test_diff.py 
824397d93e40ef94fcac62adcc00a5834a97937d 
  src/test/python/apache/aurora/client/commands/test_hooks.py 
64afce562e4810200045ab9a731f6f158c821182 
  src/test/python/apache/aurora/client/commands/test_kill.py 
825f5f13da1c8bee843581a34f3357c0fa2dbb00 
  src/test/python/apache/aurora/client/commands/test_listjobs.py 
11a255bca31383d78e8933c57e837afcbe4ef95c 
  src/test/python/apache/aurora/client/commands/test_maintenance.py 
0404a98253da8b36bfdf608494511bad8c885c72 
  src/test/python/apache/aurora/client/commands/test_restart.py 
075414bc442228e8f50aa43a70a0bf5a540f142c 
  src/test/python/apache/aurora/client/commands/test_run.py 
61eff75457264314a5626fe0a1ec7a815a093b5c 
  src/test/python/apache/aurora/client/commands/test_ssh.py 
dd62c9cca6f3e0e47e836ff2993f1515ae3ba247 
  src/test/python/apache/aurora/client/commands/test_status.py 
400e8c24edc4e0780acae355c49bdfc23c88261d 
  src/test/python/apache/aurora/client/commands/test_update.py 
72df41b041136e7cde2ffcae01ccdb52cf90ffd5 
  src/test/python/apache/aurora/client/commands/util.py 
82cadcf5c827cd7c4238ba6a9191950713dbe2fe 
  src/test/python/apache/aurora/client/test_config.py 
846975fc7bfbba38620f58a7ba739ae07521ad3b 
  src/test/python/apache/aurora/config/test_base.py 
f67dce95a9d7251f9c133eb615cbf541bc81146b 
  src/test/python/apache/aurora/config/test_thrift.py 
f845c982bf01aadd5b22a49c2b6f05a4b07a0ae2 
  src/test/python/apache/aurora/executor/common/test_task_info.py 
51f6dedbb83e9b83578ba38017414746f5b06612 
  src/test/python/apache/aurora/executor/test_gc_executor.py 
73aea7bf2aa0a0c1799c593df0ceb2d7ced4144a 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
4cd34c6a9376f6a56b8b94aaa1a4877d891d5399 

Diff: https://reviews.apache.org/r/20583/diff/


Testing
-------

You may see some errors like the following when running tests with python2.6:

Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/atexit.py",
 line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File 
"/private/var/folders/4d/9tz0cd5n2n7947xs21gspsxc0000gp/T/tmpt1EkyA/.deps/futures-2.1.2-py26-none-any.whl/concurrent/futures/thread.py",
 line 41, in _python_exit
    for thread_reference in _thread_references:
TypeError: 'NoneType' object is not iterable
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/atexit.py",
 line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File 
"/private/var/folders/4d/9tz0cd5n2n7947xs21gspsxc0000gp/T/tmpt1EkyA/.deps/futures-2.1.2-py26-none-any.whl/concurrent/futures/process.py",
 line 82, in _python_exit
    for thread_reference in _thread_references:
TypeError: 'NoneType' object is not iterable
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/atexit.py",
 line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/multiprocessing/util.py",
 line 258, in _exit_function
    info('process shutting down')
TypeError: 'NoneType' object is not callable
Error in sys.exitfunc:
Traceback (most recent call last):
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/atexit.py",
 line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/multiprocessing/util.py",
 line 258, in _exit_function
    info('process shutting down')
TypeError: 'NoneType' object is not callable


These are bugs in the stdlib that are fixed in 2.7 and are harmless.  Just FYI.


Thanks,

Brian Wickman

Reply via email to