-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20146/#review41107
-----------------------------------------------------------



dist/resources/main/org/apache/aurora/scheduler/http/assets/dictionary.js
<https://reviews.apache.org/r/20146/#comment74515>

    dist/* is ignored by git and is never checked in. I am wondering why this 
file is showing up here.



dist/resources/test/org/apache/aurora/scheduler/http/assets/dictionary.js
<https://reviews.apache.org/r/20146/#comment74516>

    dist/* is ignored by git and is never checked in. I am wondering why this 
file is showing up here.



src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js
<https://reviews.apache.org/r/20146/#comment74520>

    I am wondering if this description more sense to the user:  'This task is 
being restarted since the host is undergoing scheduled maintenance'. Your 
choice.



src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js
<https://reviews.apache.org/r/20146/#comment74518>

    Please drop THROTTLED since it is a duplicate.


- Suman Karumuri


On April 22, 2014, 9:11 p.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20146/
> -----------------------------------------------------------
> 
> (Updated April 22, 2014, 9:11 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-265
>     https://issues.apache.org/jira/browse/AURORA-265
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-265: Add missing tooltips for task states in dictionary.js
> 
> 
> Diffs
> -----
> 
>   dist/resources/main/org/apache/aurora/scheduler/http/assets/dictionary.js 
> PRE-CREATION 
>   dist/resources/test/org/apache/aurora/scheduler/http/assets/dictionary.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
> 3db34ecf9a977fe4c84d1d00990d90248b40316e 
> 
> Diff: https://reviews.apache.org/r/20146/diff/
> 
> 
> Testing
> -------
> 
> Visually inspected the scheduler w/ a sample job to verify that nothing was 
> messed up. I'm not sure how to force a task with the Vagrant file into 
> DRAINING or THROTTLED states.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Reply via email to