> On April 24, 2014, 10:39 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java, line > > 449 > > <https://reviews.apache.org/r/20689/diff/1/?file=568134#file568134line449> > > > > for (Map.Entry<String, IScheduledTask> entry : tasks.entrySet()) {
Wanted to surface any mismatches between IDs and tasks but this is even safer. Done, done and done. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20689/#review41409 ----------------------------------------------------------- On April 24, 2014, 10:25 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20689/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 10:25 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-359 > https://issues.apache.org/jira/browse/AURORA-359 > > > Repository: aurora > > > Description > ------- > > Fetching tasks before handing over to state machine. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > 74ef64dd055641d3a74074d4ea51777a70c7cf16 > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java > af17c2cf0026bea1f339993225590f43b5d44776 > > Diff: https://reviews.apache.org/r/20689/diff/ > > > Testing > ------- > > gradle build > > > Thanks, > > Maxim Khutornenko > >
