-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/
-----------------------------------------------------------

(Updated April 25, 2014, 3:15 p.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
-------

Fix typo in option name.


Bugs: aurora-356
    https://issues.apache.org/jira/browse/aurora-356


Repository: aurora


Description
-------

Add batch options to kill and killall. (This brings the kill commands in client 
v1 into parity with client v2.
At the moment, in order to avoid disrupting current users, v1 still defaults to 
non-batched operation.)


Diffs (updated)
-----

  src/main/python/apache/aurora/client/commands/core.py 
67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
  src/main/python/apache/aurora/client/options.py 
0d85c360dc4c62ab0baf58315a68a32c304fcffc 
  src/test/python/apache/aurora/client/commands/test_kill.py 
825f5f13da1c8bee843581a34f3357c0fa2dbb00 

Diff: https://reviews.apache.org/r/20723/diff/


Testing
-------

[sun-wukong incubator-aurora (batch_v1)]$ ./pants 
src/test/python/apache/aurora/client/commands:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 13 items

src/test/python/apache/aurora/client/commands/test_admin_sla.py .............

========================== 13 passed in 0.57 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 28 items

src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ......
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ...
src/test/python/apache/aurora/client/commands/test_update.py ...

========================== 28 passed in 1.47 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items

src/test/python/apache/aurora/client/commands/test_hooks.py ...

=========================== 3 passed in 1.21 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/commands/test_maintenance.py ....

=========================== 4 passed in 0.48 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_run.py .

=========================== 1 passed in 0.58 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_ssh.py .

=========================== 1 passed in 0.47 seconds ===========================
src.test.python.apache.aurora.client.commands.admin                             
.....   SUCCESS
src.test.python.apache.aurora.client.commands.core                              
.....   SUCCESS
src.test.python.apache.aurora.client.commands.hooks                             
.....   SUCCESS
src.test.python.apache.aurora.client.commands.maintenance                       
.....   SUCCESS
src.test.python.apache.aurora.client.commands.run                               
.....   SUCCESS
src.test.python.apache.aurora.client.commands.ssh                               
.....   SUCCESS
[sun-wukong incubator-aurora (batch_v1)]$


Thanks,

Mark Chu-Carroll

Reply via email to