> On April 25, 2014, 8:54 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java, line 81
> > <https://reviews.apache.org/r/20732/diff/1/?file=568836#file568836line81>
> >
> >     How would you feel about nuking this method and moving the 
> > implementation to SchedulerThriftInterface?  It's the only consumer, making 
> > this a proxy method to StateManager.

Well, this is true about all methods in SchedulerCore. I'd rather minimize the 
diff here and address the refactoring in AURORA-94.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/#review41522
-----------------------------------------------------------


On April 25, 2014, 8:41 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20732/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 8:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-345
>     https://issues.apache.org/jira/browse/AURORA-345
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Converted INVALID_REQUEST to OK and modified returned message.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> e62f6c62452a1e1ac93baec7419580de2f40f0de 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7c557931b2ce05c7d14499954fe3b89bb5853faa 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d7dbfaa76b277b028e56ed633ea2a032935e26db 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c23c94807b97bcf77c2c155ee2039deebfaa090c 
> 
> Diff: https://reviews.apache.org/r/20732/diff/
> 
> 
> Testing
> -------
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to