> On April 28, 2014, 11 p.m., Maxim Khutornenko wrote: > > FWIW, I found gradle run incredibly valuable when working on a fix for > > AURORA-366. Doing the same in Vagrant would take order of magnitude more > > time. I vote in favor of keeping the isolated mode as a quick dev/debug > > iteration way. > > Bill Farner wrote: > The time sink is not inherent to running in vagrant, but that we have not > yet invested time in streamlining the code iteration process in the vagrant > environment (i.e. rather than destroy/up). Keeping the isolated mode around > doesn't nudge us to define that process. > > Suman Karumuri wrote: > Can we keep gradle run target without the isolated scheduler module? I > can see a how it can make testing quicker.
> Can we keep gradle run target without the isolated scheduler module? Have any ideas? I don't see a path without moving the existing "if production do this, else do this" scattered around. > I can see a how it can make testing quicker. It really shouldn't by any meaningful amount. "vagrant up" will always be slower than "./gradlew run", but my point is that we need to define a development flow that doesn't require repeated vagrant up/destroy. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/#review41646 ----------------------------------------------------------- On April 24, 2014, 4:22 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20648/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 4:22 a.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-340 > https://issues.apache.org/jira/browse/AURORA-340 > > > Repository: aurora > > > Description > ------- > > Remove IsolatedSchedulerModule and surrounding code. > > > Diffs > ----- > > build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 > src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java > 9a78fb9be8578f8cea2e51c0ebf385aafdc8b2a9 > > src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java > 1bfd4b69584122f62616ce93098a56fe3cf195d8 > src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java > 9186aebef2babc4a76fe05eb3b412be26d7de3c6 > > src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java > d8f19e6c1eac1567b3194c5d4ebeb0d5b95073e6 > src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java > cc31187607e89a9daebe071a8a180d56d873e4c5 > > Diff: https://reviews.apache.org/r/20648/diff/ > > > Testing > ------- > > ./gradlew build > sh examples/vagrant/test_tutorial.sh > > > Thanks, > > Bill Farner > >
