-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20808/#review41784
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java
<https://reviews.apache.org/r/20808/#comment75379>

    s/n instance of//



src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java
<https://reviews.apache.org/r/20808/#comment75381>

    Nit-picking, but as a reader, i'd find this context more valuable right 
down in the body of afterExecute.  When trying to grok the body of that method, 
i probably wouldn't think to look at the javadoc tags.



src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java
<https://reviews.apache.org/r/20808/#comment75380>

    s/version of //



src/test/java/org/apache/aurora/scheduler/base/AsyncUtilTest.java
<https://reviews.apache.org/r/20808/#comment75378>

    Can you validate executor.submit() as well?


- Bill Farner


On April 29, 2014, 9:07 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20808/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 9:07 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-366
>     https://issues.apache.org/jira/browse/AURORA-366
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Moved ScheduledThreadPoolExecutor creation into AsyncUtil to share across. 
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 00923723a60866145d481ea505b9a51d0e54832c 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 535acd21abda1473c1a364230bbd5b6b92e228bd 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
> 6aff091d9afefc73af666f980ef96acd726aec20 
>   src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> 0c6a2b8ea40c5459950037bc5683b5072f6731f5 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> 6c723393000133452afd841cbaef4dad3c5806b5 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 5512a447e28d5166681cc7dcc82bf60a5500b162 
>   src/test/java/org/apache/aurora/scheduler/base/AsyncUtilTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20808/diff/
> 
> 
> Testing
> -------
> 
> Manual testing via gradle run (any ideas on how to unit test this properly 
> without passing a logger as arg are welcome).
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to