> On May 2, 2014, 9:30 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 89 > > <https://reviews.apache.org/r/21025/diff/1/?file=573840#file573840line89> > > > > If we're making a breaking change anyway would it make sense to take > > care of this deprecation now?
I would rather avoid bundling it into this RB. I will create a ticket to track it separately. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21025/#review42062 ----------------------------------------------------------- On May 2, 2014, 8:26 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21025/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 8:26 p.m.) > > > Review request for Aurora, Kevin Sweeney and Brian Wickman. > > > Bugs: AURORA-376 > https://issues.apache.org/jira/browse/AURORA-376 > > > Repository: aurora > > > Description > ------- > > Adjusting default health check config values. > > > Diffs > ----- > > docs/client-commands.md 098d261de2cca99933f5d7134417f59971040b3b > docs/configuration-reference.md 775e652bb99887135387169a44a54dae940a8826 > docs/configuration-tutorial.md c7d970ce0f9cb504aff3c38577365534ee241fe1 > src/main/python/apache/aurora/config/schema/base.py > 89931ab341bbc3a36931ecca08ac9fbcc31cb6b7 > src/main/python/apache/aurora/executor/common/health_checker.py > 503d5c64b8a7dc5030d25c34d3ce6d9445abd12d > > Diff: https://reviews.apache.org/r/21025/diff/ > > > Testing > ------- > > ./pants src/test/python:all -vxs > > > Thanks, > > Maxim Khutornenko > >
